[ROCm] Added include of hipblas.h in hipblaslt_wrapper.h #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruturaj4
approved these changes
Oct 22, 2024
jayfurmanek
force-pushed
the
rocm-jaxlib-v0.4.30-qa-hipblasfix
branch
from
6751aca
to
e8b1ff4
Compare
|
IIUC this fix is because that hipblaslt recently changed the dependent lib(header) from hipblas package to hipblas-common package. may I ask is it for all ROCm version or just ROCm6.2+ ? what about previous ROCm versions? e.g., 6.1, 6.0 or 5.7? |
|
The fix will work on previous versions too, but I think this is primarily a fix for 6.3? |
|
Yes, we need this ROCm 6.3 patch for previous QA branches as well. In addition, shall we upstream this fix for JAX/TF/XLA on rocm6.3? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue from SWDEV-482396 for rocm-jaxlib-v0.4.30-qa branch.