From 0c2a2ed344a4e94efdd35d0aa5445d48158330ba Mon Sep 17 00:00:00 2001 From: Christian Schabesberger Date: Fri, 5 Nov 2021 23:36:20 +0100 Subject: [PATCH 1/2] make banner images show for nordbayern again --- bridges/NordbayernBridge.php | 23 ++++++++++++++++++----- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/bridges/NordbayernBridge.php b/bridges/NordbayernBridge.php index 52b1f3eca5b..cea9b710c0e 100644 --- a/bridges/NordbayernBridge.php +++ b/bridges/NordbayernBridge.php @@ -63,6 +63,19 @@ private function getUseFullContent($rawContent) { return $content; } + private function getValidImages($pictures) { + $images = array(); + if(!empty($pictures)) { + for($i = 0; $i < count($pictures); $i++) { + $imgUrl = $pictures[$i]->find('img', 0)->src; + if(strcmp($imgUrl, 'https://www.nordbayern.de/img/nb/logo-vnp.png') !== 0) { + array_push($images, $imgUrl); + } + } + } + return $images; + } + private function handleArticle($link) { $item = array(); $article = getSimpleHTMLDOM($link); @@ -78,8 +91,9 @@ private function handleArticle($link) { //first get images from content $pictures = $article->find('picture'); - if(!empty($pictures)) { - $bannerUrl = $pictures[0]->find('img', 0)->src; + $images = self::getValidImages($pictures); + if(!empty($images)) { + $bannerUrl = $images[0]; $item['content'] .= ''; } @@ -93,9 +107,8 @@ private function handleArticle($link) { $item['content'] .= self::getUseFullContent($content); } - for($i = 1; $i < count($pictures); $i++) { - $imgUrl = $pictures[$i]->find('img', 0)->src; - $item['content'] .= ''; + for($i = 1; $i < count($images); $i++) { + $item['content'] .= ''; } // exclude police reports if descired From 2d0733ce091bf935acfc9073dafb22af954e7288 Mon Sep 17 00:00:00 2001 From: Christian Schabesberger Date: Sat, 6 Nov 2021 09:35:07 +0100 Subject: [PATCH 2/2] make author portrait not apear as article banner for nordbayern --- bridges/NordbayernBridge.php | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/bridges/NordbayernBridge.php b/bridges/NordbayernBridge.php index cea9b710c0e..ba1671b285b 100644 --- a/bridges/NordbayernBridge.php +++ b/bridges/NordbayernBridge.php @@ -93,7 +93,16 @@ private function handleArticle($link) { $pictures = $article->find('picture'); $images = self::getValidImages($pictures); if(!empty($images)) { - $bannerUrl = $images[0]; + // If there is an author info block + // the first immage will be the portrait of the author + // and not the article banner. The banner in this + // case will be the second image. + if ($article->find('div[class=authorinfo]', 0) == null) { + $bannerUrl = $images[0]; + } else { + $bannerUrl = $images[1]; + } + $item['content'] .= ''; } @@ -107,7 +116,7 @@ private function handleArticle($link) { $item['content'] .= self::getUseFullContent($content); } - for($i = 1; $i < count($images); $i++) { + for($i = 0; $i < count($images); $i++) { $item['content'] .= ''; }