From 63b76fb7d3789a4406af7a3b2e60c65ab172e34a Mon Sep 17 00:00:00 2001 From: mruac Date: Sun, 30 Jul 2023 20:42:59 +0930 Subject: [PATCH 1/3] Fix php8.2 deprecated warning Fix php8.2 warning: `Deprecated: Creation of dynamic property is deprecated` --- lib/BridgeAbstract.php | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/lib/BridgeAbstract.php b/lib/BridgeAbstract.php index eb9d5a3cc01..66c9e3ed60b 100644 --- a/lib/BridgeAbstract.php +++ b/lib/BridgeAbstract.php @@ -112,6 +112,16 @@ abstract class BridgeAbstract implements BridgeInterface * @var string */ protected $queriedContext = ''; + + /** + * Holds the list of bridge-specific configurations from config.ini.php, used by the bridge. + * + * Do not access this parameter directly! + * Use {@see BridgeAbstract::getConfiguration()} and {@see BridgeAbstract::getOption(string $name)} instead. + * + * @var array + */ + protected array $configuration = []; /** {@inheritdoc} */ public function getItems() From 8d90f19bb09e5c106261c1f769615164550e9a78 Mon Sep 17 00:00:00 2001 From: Dag Date: Tue, 1 Aug 2023 19:17:23 +0200 Subject: [PATCH 2/3] fix --- lib/BridgeAbstract.php | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/lib/BridgeAbstract.php b/lib/BridgeAbstract.php index 66c9e3ed60b..62979adecc4 100644 --- a/lib/BridgeAbstract.php +++ b/lib/BridgeAbstract.php @@ -112,16 +112,11 @@ abstract class BridgeAbstract implements BridgeInterface * @var string */ protected $queriedContext = ''; - + /** * Holds the list of bridge-specific configurations from config.ini.php, used by the bridge. - * - * Do not access this parameter directly! - * Use {@see BridgeAbstract::getConfiguration()} and {@see BridgeAbstract::getOption(string $name)} instead. - * - * @var array */ - protected array $configuration = []; + private array $configuration = []; /** {@inheritdoc} */ public function getItems() From eaa6a57c7b422f5ce86b84ad5bc830213d264a58 Mon Sep 17 00:00:00 2001 From: Dag Date: Tue, 1 Aug 2023 19:22:44 +0200 Subject: [PATCH 3/3] refactor: remove unused method --- lib/BridgeAbstract.php | 8 -------- lib/BridgeInterface.php | 5 ----- 2 files changed, 13 deletions(-) diff --git a/lib/BridgeAbstract.php b/lib/BridgeAbstract.php index 62979adecc4..679e69af675 100644 --- a/lib/BridgeAbstract.php +++ b/lib/BridgeAbstract.php @@ -58,8 +58,6 @@ abstract class BridgeAbstract implements BridgeInterface /** * Configuration for the bridge - * - * Use {@see BridgeAbstract::getConfiguration()} to read this parameter */ const CONFIGURATION = []; @@ -366,12 +364,6 @@ public function getIcon() return static::URI . '/favicon.ico'; } - /** {@inheritdoc} */ - public function getConfiguration() - { - return static::CONFIGURATION; - } - /** {@inheritdoc} */ public function getParameters() { diff --git a/lib/BridgeInterface.php b/lib/BridgeInterface.php index b461ed12cce..977ad7f61d5 100644 --- a/lib/BridgeInterface.php +++ b/lib/BridgeInterface.php @@ -60,11 +60,6 @@ interface BridgeInterface */ public function collectData(); - /** - * Get the user's supplied configuration for the bridge - */ - public function getConfiguration(); - /** * Returns the value for the selected configuration *