ENH: Reorder the photon counts inside one-step filter #621
Conversation
| // If subsets are used the photons counts and geometry are shuffled, then geometry need to be set again. | ||
| if (m_NumberOfSubsets != 1) | ||
| { | ||
| m_ReorderPhotonCountsFilter->Update(); | ||
| this->SetGeometry(m_ReorderPhotonCountsFilter->GetOutputGeometry()); | ||
| m_ForwardProjectionFilter->SetGeometry(this->m_Geometry); | ||
| m_SingleComponentForwardProjectionFilter->SetGeometry(this->m_Geometry); | ||
| m_GradientsBackProjectionFilter->SetGeometry(this->m_Geometry.GetPointer()); | ||
| m_HessiansBackProjectionFilter->SetGeometry(this->m_Geometry.GetPointer()); | ||
| } |
There was a problem hiding this comment.
When I look at the code of ReorderProjectionsImageFilter, I don't see why this is required. It should be sufficient to do it in UpdateOutputInformation no?
There was a problem hiding this comment.
I tried by setting the new geometry only in the GenerateInputRequestedRegion() method but then I get this error Mismatch between the number of projections and the geometry entries. Geometry has 0 entries, which is less than the last index of the projections stack. Maybe I'm missing something here.
There was a problem hiding this comment.
Reading section 8.3.2 of the software guide, I think the checks on the geometry should be in the VerifyInputInformation and not in the VerifyPreconditions so that the geometry can be modified in the UpdateOutputInformation. Does it tell you which filter complains with this error message?
There was a problem hiding this comment.
Yes the error comes from the BackProjectionImageFilter here.
There was a problem hiding this comment.
If we want to avoid doing this, we need to rewrite ReorderProjectionsImageFilter to create the geometry in GenerateOutputInformation. That's for a different PR I guess, thanks for finding the proposed solution.
When subsets are used, the photon counts are shuffled before doing the reconstruction. The shuffle was done in the application and not in the filter which is not how it is done for the others reconstruction filters.
|
The last force-pushed fix the bug and update the documentation. |
When subsets are used, the photon counts are shuffled before doing the reconstruction. The shuffle was done in the application and not in the filter which is not how it is done for the others reconstruction filters.