-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade rubocop to Latest #37
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Benjamin Reynolds <11561578+benreyn@users.noreply.github.com> Co-Authored-By: James Nebeker <4481935+jnebeker@users.noreply.github.com> Co-Authored-By: Aaron Kromer <1524496+cupakromer@users.noreply.github.com> Co-Authored-By: Sam Kim <16728352+sam-kim@users.noreply.github.com>
Co-Authored-By: Benjamin Reynolds <11561578+benreyn@users.noreply.github.com> Co-Authored-By: James Nebeker <4481935+jnebeker@users.noreply.github.com> Co-Authored-By: Aaron Kromer <1524496+cupakromer@users.noreply.github.com> Co-Authored-By: Sam Kim <16728352+sam-kim@users.noreply.github.com>
Co-Authored-By: Benjamin Reynolds <11561578+benreyn@users.noreply.github.com> Co-Authored-By: James Nebeker <4481935+jnebeker@users.noreply.github.com> Co-Authored-By: Aaron Kromer <1524496+cupakromer@users.noreply.github.com> Co-Authored-By: Sam Kim <16728352+sam-kim@users.noreply.github.com>
yarmiganosca
force-pushed
the
upgrade-rubocop
branch
from
November 19, 2021 20:09
368466d
to
0b7e109
Compare
Co-authored-by: James Nebeker <jnebeker@users.noreply.github.com> Co-authored-by: Aaron Kromer <cupakromer@users.noreply.github.com> Co-authored-by: Sam Kim <sam-kim@users.noreply.github.com> Co-authored-by: Alex Stone <alexstone@users.noreply.github.com>
Co-authored-by: James Nebeker <jnebeker@users.noreply.github.com> Co-authored-by: Aaron Kromer <cupakromer@users.noreply.github.com> Co-authored-by: Sam Kim <sam-kim@users.noreply.github.com> Co-authored-by: Alex Stone <alexstone@users.noreply.github.com>
yarmiganosca
force-pushed
the
upgrade-rubocop
branch
from
November 19, 2021 20:53
6b2c4c3
to
0ec5173
Compare
Co-Authored-By: James Nebeker <4481935+jnebeker@users.noreply.github.com> Co-Authored-By: Sam Kim <16728352+sam-kim@users.noreply.github.com> Co-Authored-By: JC Avena <200333+jcavena@users.noreply.github.com>
Co-authored-by: Alex Stone <astone@radiusnetworks.com> Co-authored-by: Eric Ouellette <eric.s.ouellette@gmail.com> Co-authored-by: James Nebeker <jnebeker@radiusnetworks.com> Co-authored-by: JC Avena <jcavena@gmail.com>
Co-authored-by: Alex Stone <astone@radiusnetworks.com> Co-authored-by: Eric Ouellette <eric.s.ouellette@gmail.com> Co-authored-by: James Nebeker <jnebeker@radiusnetworks.com> Co-authored-by: JC Avena <jcavena@gmail.com>
Co-authored-by: Alex Stone <astone@radiusnetworks.com> Co-authored-by: Eric Ouellette <eric.s.ouellette@gmail.com> Co-authored-by: James Nebeker <jnebeker@radiusnetworks.com> Co-authored-by: JC Avena <jcavena@gmail.com>
benreyn
force-pushed
the
upgrade-rubocop
branch
from
January 7, 2022 21:03
f944ca3
to
f602717
Compare
jnebeker
approved these changes
Jan 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉
Sadly it looks like they just released v1.25.0 so we still have one more before we catch up. 😩
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-By: Benjamin Reynolds 11561578+benreyn@users.noreply.github.com
Co-Authored-By: James Nebeker 4481935+jnebeker@users.noreply.github.com
Co-Authored-By: Aaron Kromer 1524496+cupakromer@users.noreply.github.com
Co-Authored-By: Sam Kim 16728352+sam-kim@users.noreply.github.com