Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade rubocop to Latest #37

Merged
merged 11 commits into from
Jan 21, 2022
Merged

Upgrade rubocop to Latest #37

merged 11 commits into from
Jan 21, 2022

Conversation

alexstone
Copy link
Contributor

Co-Authored-By: Benjamin Reynolds 11561578+benreyn@users.noreply.github.com
Co-Authored-By: James Nebeker 4481935+jnebeker@users.noreply.github.com
Co-Authored-By: Aaron Kromer 1524496+cupakromer@users.noreply.github.com
Co-Authored-By: Sam Kim 16728352+sam-kim@users.noreply.github.com

Co-Authored-By: Benjamin Reynolds <11561578+benreyn@users.noreply.github.com>
Co-Authored-By: James Nebeker <4481935+jnebeker@users.noreply.github.com>
Co-Authored-By: Aaron Kromer <1524496+cupakromer@users.noreply.github.com>
Co-Authored-By: Sam Kim <16728352+sam-kim@users.noreply.github.com>
@alexstone alexstone assigned alexstone and unassigned alexstone Nov 12, 2021
alexstone and others added 2 commits November 12, 2021 15:46
Co-Authored-By: Benjamin Reynolds <11561578+benreyn@users.noreply.github.com>
Co-Authored-By: James Nebeker <4481935+jnebeker@users.noreply.github.com>
Co-Authored-By: Aaron Kromer <1524496+cupakromer@users.noreply.github.com>
Co-Authored-By: Sam Kim <16728352+sam-kim@users.noreply.github.com>
Co-Authored-By: Benjamin Reynolds <11561578+benreyn@users.noreply.github.com>
Co-Authored-By: James Nebeker <4481935+jnebeker@users.noreply.github.com>
Co-Authored-By: Aaron Kromer <1524496+cupakromer@users.noreply.github.com>
Co-Authored-By: Sam Kim <16728352+sam-kim@users.noreply.github.com>
yarmiganosca and others added 2 commits November 19, 2021 15:53
Co-authored-by: James Nebeker <jnebeker@users.noreply.github.com>
Co-authored-by: Aaron Kromer <cupakromer@users.noreply.github.com>
Co-authored-by: Sam Kim <sam-kim@users.noreply.github.com>
Co-authored-by: Alex Stone <alexstone@users.noreply.github.com>
Co-authored-by: James Nebeker <jnebeker@users.noreply.github.com>
Co-authored-by: Aaron Kromer <cupakromer@users.noreply.github.com>
Co-authored-by: Sam Kim <sam-kim@users.noreply.github.com>
Co-authored-by: Alex Stone <alexstone@users.noreply.github.com>
@yarmiganosca yarmiganosca changed the title Upgrade rubocop to 1.8.0 Upgrade rubocop to 1.12.1 Nov 19, 2021
yarmiganosca and others added 6 commits December 10, 2021 15:36
Co-Authored-By: James Nebeker <4481935+jnebeker@users.noreply.github.com>
Co-Authored-By: Sam Kim <16728352+sam-kim@users.noreply.github.com>
Co-Authored-By: JC Avena <200333+jcavena@users.noreply.github.com>
Co-authored-by: Alex Stone <astone@radiusnetworks.com>
Co-authored-by: Eric Ouellette <eric.s.ouellette@gmail.com>
Co-authored-by: James Nebeker <jnebeker@radiusnetworks.com>
Co-authored-by: JC Avena <jcavena@gmail.com>
Co-authored-by: Alex Stone <astone@radiusnetworks.com>
Co-authored-by: Eric Ouellette <eric.s.ouellette@gmail.com>
Co-authored-by: James Nebeker <jnebeker@radiusnetworks.com>
Co-authored-by: JC Avena <jcavena@gmail.com>
Co-authored-by: Alex Stone <astone@radiusnetworks.com>
Co-authored-by: Eric Ouellette <eric.s.ouellette@gmail.com>
Co-authored-by: James Nebeker <jnebeker@radiusnetworks.com>
Co-authored-by: JC Avena <jcavena@gmail.com>
@benreyn benreyn changed the title Upgrade rubocop to 1.12.1 Upgrade rubocop to Latest Jan 14, 2022
@benreyn benreyn marked this pull request as ready for review January 14, 2022 19:03
@benreyn benreyn requested a review from a team January 19, 2022 19:16
Copy link
Contributor

@jnebeker jnebeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

Sadly it looks like they just released v1.25.0 so we still have one more before we catch up. 😩

@benreyn benreyn merged commit 481ef59 into main Jan 21, 2022
@benreyn benreyn deleted the upgrade-rubocop branch January 21, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants