Update rubocop requirement from ~> 1.25.0 to >= 1.25, < 1.29 #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.25.0...v1.28.0) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
the
dependencies
IgnoredPatterns was deprecated in RuboCop v1.28.0 in favor of AllowedPatterns, which is a little easier to comprehend.
|
For the next dependency meeting (May the 4th!):
|
|
A newer version of rubocop exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
Mostly replacing ENV[] with ENV.fetch(), also ignore RuboCop for some
`.map {}.to_h` calls that are used in benchmarks.
If we're using consecutive conditionals we probably know what we're doing. The good thing is this cop will still flag consecutive conditionals that are identical.
yarmiganosca
force-pushed
the
dependabot/bundler/rubocop-gte-1.25-and-lt-1.29
branch
from
3f65800
to
bf41978
Compare
|
@yarmiganosca You should tell da bot to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the requirements on rubocop to permit the latest version.
Changelog
Sourced from rubocop's changelog.
... (truncated)
Commits
24ab7b2Cut 1.28.03e11aa1Update Changelog7fcb272Support autocorrection forStyle/RedundantInitializee491166Update uses ofIgnoredPatternstoAllowedPatterns.8ac5b59Add obsoletion rules forAllowedPatterns.7c9e611RenameIgnoredPatternstoAllowedPatterns.e62a69a[Fix #10553] Fix crash with trailing tabs in heredocs for `Layout/TrailingWhi...b4ea4c6[Fix #10280] AddAllowCommentsoption toStyle/SymbolProc7812417[Fix #10488] Fix autocorrection forLayout/MultilineMethodCallIndentationb...a2cfdc1Fix an incorrect autocorrect forStyle/SpecialGlobalVarsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)