Security Vulnerability "/_data_/…/storage/cfg/…/…/accounts"

[the-djmaze]

RainLoop version, browser, OS:
v1.16

Expected behavior:
File can't be decrypted on (backup) server.

actual behavior:
File can be decrypted on (backup) server.

Steps to reproduce the problem:
When calling \RainLoop\Actions->SetAccounts()
It will store an array of values from \RainLoop\Model\Account->GetAuthToken()
Which in turn calls \RainLoop\Utils::EncodeKeyValues()
And that calls \RainLoop\Utils::EncryptString(@\serialize($aValues), \md5(APP_SALT))

When someone/something has access to the SALT.php file,
it can decode the encrypted accounts and gain all passwords.

These days with server breaches, ransomware, other attacks and the increase of backup behavior, the chance of being listed on "have i been pwned" has increased and the above mentioned issue becomes a bigger vulnerability.

Solutions:

1. Encrypting the file based on user cookie is very unreliable and has a high fail rate.
2. Encrypting with a server stored key (like the SALT.php) opens this issue
3. Encrypting using the main account password (the login) fails when password is changed or when using OAUTHBEARER/XOAuth2
4. Only encrypting the account passwords with (3) keeps the accounts, but only login will fail.

With (4) you could store an HMAC of the encrypted password to check if the account login works.

Same issue applies to the 'contacts_sync' file

[Neustradamus]

Please use SnappyMail from @the-djmaze, we can thanks for this work!

• https://snappymail.eu/
• https://github.com/the-djmaze/snappymail/

Please note that SnappyMail supports SCRAM-SHA-* for connection, very good security:

• SCRAM-SHA-1-PLUS + SCRAM-SHA-256-PLUS + SCRAM-SHA-512(-PLUS) + SCRAM-SHA3-512(-PLUS) supports the-djmaze/snappymail#182
• https://github.com/the-djmaze/snappymail/blob/master/snappymail/v/0.0.0/app/libraries/RainLoop/Model/Account.php

Linked to:

• RainLoop is dead, if possible switch to SnappyMail: https://github.com/the-djmaze/snappymail #2185
• Sec: Fix CVE-2022-29360 XSS vulnerability #2183
• Please fix the exploit, thanks! CVE-2022-29360 https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2022-29360 https://www.ddosi.org/cve-2022-29360/ https://www.youtube.com/watch?v=6dSiQH0pijk #2180
• Jan 2022: Is rainloop still maintained? #2162
• Security Contact for high severity Security Issue #2142
• Security Vulnerability "/_data_/…/storage/cfg/…/…/accounts" #2134
• Is this project dead? #1831