From 08b90ee54607aa6882070c5e6384bab1376655d7 Mon Sep 17 00:00:00 2001 From: Darshan Sen Date: Mon, 22 May 2023 15:59:43 +0530 Subject: [PATCH] test,doc,sea: run SEA tests on ppc64 The recent Postject upgrade, https://github.com/nodejs/node/pull/48072, included a performance improvement for the injection operation (see https://github.com/nodejs/postject/pull/86), so now it might be possible to run the SEA tests on the ppc64 architecture runners on Jenkins, which was previously getting timed out. Signed-off-by: Darshan Sen --- doc/api/single-executable-applications.md | 2 +- test/common/sea.js | 4 ---- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/doc/api/single-executable-applications.md b/doc/api/single-executable-applications.md index 7c929d56f58dca..0332a555449928 100644 --- a/doc/api/single-executable-applications.md +++ b/doc/api/single-executable-applications.md @@ -233,7 +233,7 @@ platforms: * Windows * macOS * Linux (all distributions [supported by Node.js][] except Alpine and all - architectures [supported by Node.js][] except s390x and ppc64) + architectures [supported by Node.js][] except s390x) This is due to a lack of better tools to generate single-executables that can be used to test this feature on other platforms. diff --git a/test/common/sea.js b/test/common/sea.js index b2df249cb9fcc3..bb337f176f2cc2 100644 --- a/test/common/sea.js +++ b/test/common/sea.js @@ -40,10 +40,6 @@ function skipIfSingleExecutableIsNotSupported() { if (process.arch === 's390x') { common.skip('On s390x, postject fails with `memory access out of bounds`.'); } - - if (process.arch === 'ppc64') { - common.skip('On ppc64, this test times out.'); - } } }