From ec95b21e04cc7d9e9b28d1a035564a31a2dce3e0 Mon Sep 17 00:00:00 2001 From: rajasekhar-vuppala Date: Fri, 7 Jun 2024 05:47:06 -0400 Subject: [PATCH] changes based on the comments --- .../src/datahub/ingestion/source/sql/vertica.py | 10 ---------- .../tests/integration/vertica/docker-compose.yml | 1 + .../tests/integration/vertica/vertica_to_file.yml | 2 +- 3 files changed, 2 insertions(+), 11 deletions(-) diff --git a/metadata-ingestion/src/datahub/ingestion/source/sql/vertica.py b/metadata-ingestion/src/datahub/ingestion/source/sql/vertica.py index e8043a49da5f7..5b1a815e178b1 100644 --- a/metadata-ingestion/src/datahub/ingestion/source/sql/vertica.py +++ b/metadata-ingestion/src/datahub/ingestion/source/sql/vertica.py @@ -135,16 +135,6 @@ def create(cls, config_dict: Dict, ctx: PipelineContext) -> "VerticaSource": def get_workunits_internal(self) -> Iterable[Union[MetadataWorkUnit, SqlWorkUnit]]: yield from super().get_workunits_internal() sql_config = self.config - if logger.isEnabledFor(logging.DEBUG): - # If debug logging is enabled, we also want to echo each SQL query issued. - sql_config.options.setdefault("echo", True) - - # Extra default SQLAlchemy option for better connection pooling and threading. - # https://docs.sqlalchemy.org/en/14/core/pooling.html#sqlalchemy.pool.QueuePool.params.max_overflow - if sql_config.is_profiling_enabled(): - sql_config.options.setdefault( - "max_overflow", sql_config.profiling.max_workers - ) for inspector in self.get_inspectors(): profiler = None diff --git a/metadata-ingestion/tests/integration/vertica/docker-compose.yml b/metadata-ingestion/tests/integration/vertica/docker-compose.yml index 24cc4ae715d36..1ba7990c826b2 100644 --- a/metadata-ingestion/tests/integration/vertica/docker-compose.yml +++ b/metadata-ingestion/tests/integration/vertica/docker-compose.yml @@ -4,6 +4,7 @@ services: platform: linux/amd64 environment: APP_DB_USER: "dbadmin" + APP_DB_PASSWORD: "abc123" container_name: vertica-ce image: vertica/vertica-ce:23.4.0-0 ports: diff --git a/metadata-ingestion/tests/integration/vertica/vertica_to_file.yml b/metadata-ingestion/tests/integration/vertica/vertica_to_file.yml index 2b3e63c40071e..6f628011279ed 100644 --- a/metadata-ingestion/tests/integration/vertica/vertica_to_file.yml +++ b/metadata-ingestion/tests/integration/vertica/vertica_to_file.yml @@ -4,7 +4,7 @@ source: host_port: 127.0.0.1:5433 database: Vmart username: dbadmin - password: + password: abc123 include_tables: true include_views: true include_projections: true