Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules which cannot be accessed are not included in projects.json #397

Open
CIAvash opened this issue Jun 13, 2018 · 6 comments
Open

Modules which cannot be accessed are not included in projects.json #397

CIAvash opened this issue Jun 13, 2018 · 6 comments

Comments

@CIAvash
Copy link
Member

CIAvash commented Jun 13, 2018

If a module cannot be reached because the host server is down, the module won't be included in projects1.json and projects.json. And the module manager(zef) would not be able to find the module, although the module exists, it just could not be accessed.

Apparently projects1.json is generated in server/updatelist.pl and projects.json is generated in updatelist.pl.

It seems zef has 4 mirrors for getting the list of modules, first two of which are projects1.json and projects.json.

Related IRC logs

@moritz
Copy link
Contributor

moritz commented Jun 13, 2018

What's the point of offering a module for installation when it cannot be installed?

I consider this a feature.

@CIAvash
Copy link
Member Author

CIAvash commented Jun 13, 2018

Because it misleads the user. If they try to install a module and zef tells them it cannot find it, then they think it might have been removed or something. They might not try to install it again. But if zef shows an error that tells the user it cannot access it(for example "500 internal server error"), then they know there is something wrong with the server.

Yesterday I tried to install my own module and I was really confused, I thought maybe somebody accidentally removed it from the list. Then After some investigation I found out that Gitlab was down and that was what caused it.

@rafaelschipiura
Copy link
Contributor

You mean that the error messages should be more specific?

@CIAvash
Copy link
Member Author

CIAvash commented Jun 13, 2018

Yes, but It's not just the error message. If projects1.json(the generated list) is incomplete, the only thing zef can say is that it cannot find the module.

@JJ
Copy link
Contributor

JJ commented Jul 28, 2018

Not clear what could be the solution here. Any suggestion?

@CIAvash
Copy link
Member Author

CIAvash commented Jul 29, 2018

One solution was offered by Zoffix: "probably could add a conditional in here that would read use dist's info from previous run if we fail to fetch the new one".

But there are 2 scripts generating 2 different lists. And then there are two other mirrors zef uses, I don't know if they have this problem or not.

cc @ugexe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants