Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S32-io/IO-Socket-INET-UNIX.t is busted #718

Open
Altai-man opened this issue Feb 21, 2021 · 3 comments · May be fixed by #732
Open

S32-io/IO-Socket-INET-UNIX.t is busted #718

Altai-man opened this issue Feb 21, 2021 · 3 comments · May be fixed by #732

Comments

@Altai-man
Copy link
Member

The test creates a relative file in the directory to work with and this has costed us some hours (and money for me) lost to release, which is LTA.

The failure looks this way:

># Socket path '/home/koto/Devel/perl6-dev/R/rakudo/tools/releasable/temp/rakudo-test/rakudo-2021.02/t/spec/S32-io/test.sock' is too long (max length supported by this platform is 107 characters)

Why not open a file in $*TMP instead to prevent ^?
lizmat added a commit that referenced this issue Feb 21, 2021
@lizmat
Fix for #718
1a5c3dc
@lizmat
Copy link
Contributor

lizmat commented Feb 21, 2021

Was that the only one failing, or were there more like this?

@Altai-man
Copy link
Member Author

Thanks for replying quickly!

This is the only one failing persistently and confusingly, I think, others are fine.

There are also https://github.com/Raku/roast/blob/master/S17-procasync/kill.t and https://github.com/Raku/roast/blob/master/MISC/bug-coverage-stress-6.d.t that fail consistently under heavy load (they are flappers, really) which I would like to do something with, but I remember last time it was discussed people talking about impossibility to really fix it anyhow.

Kaiepi pushed a commit to Kaiepi/roast that referenced this issue Apr 4, 2021
@lizmat @Kaiepi
Fix for Raku#718
88dab4a
@Kaiepi
Copy link
Contributor

Kaiepi commented Apr 10, 2021 •
edited
Loading

Sorry for the late response. This is a huge oversight on my part, and should be a relative path of some sort; $*TMPDIR risks being too long if a custom directory for it is set in the environment.

@Kaiepi Kaiepi linked a pull request Apr 10, 2021 that will close this issue
Open
Kaiepi added a commit to Kaiepi/roast that referenced this issue Apr 10, 2021
@Kaiepi
Change directory to $*TMPDIR and unlink closed UNIX sockets
202dc89 
Fixes Raku#718
Kaiepi added a commit to Kaiepi/roast that referenced this issue Apr 10, 2021
@Kaiepi
Change directory to $*TMPDIR before UNIX socket tests
9390d06 
Fixes Raku#718
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change directory to $*TMPDIR Kaiepi/roast
3 participants
@lizmat @Altai-man @Kaiepi