Merge pull request #38 from sreynen/patch-1

Default type on input set as attribute

Author: Raynos

dom-element.js

@@ -104,18 +104,25 @@ DOMElement.prototype.setAttributeNS =
             prefix = name.substr(0, colonPosition)
             localName = name.substr(colonPosition + 1)
         }
-        var attributes = this._attributes[namespace] || (this._attributes[namespace] = {})
-        attributes[localName] = {value: value, prefix: prefix}
+        if (this.tagName === 'INPUT' && name === 'type') {
+          this.type = value;
+        }
+        else {
+          var attributes = this._attributes[namespace] || (this._attributes[namespace] = {})
+          attributes[localName] = {value: value, prefix: prefix}
+        }
     }
 
 DOMElement.prototype.getAttributeNS =
     function _Element_getAttributeNS(namespace, name) {
         var attributes = this._attributes[namespace];
         var value = attributes && attributes[name] && attributes[name].value
+        if (this.tagName === 'INPUT' && name === 'type') {
+          return this.type;
+        }
         if (typeof value !== "string") {
             return null
         }
-
         return value
     }
 

test/test-document.js

@@ -326,11 +326,19 @@ function testDocument(document) {
 
     test("input has type=text by default", function (assert) {
         var elem = document.createElement("input")
-        assert.equal(elem.type, "text");
+        assert.equal(elem.getAttribute("type"), "text");
         assert.equal(elemString(elem), "<input type=\"text\" />")
         assert.end()
     })
 
+    test("input type=text can be overridden", function (assert) {
+        var elem = document.createElement("input")
+        elem.setAttribute("type", "hidden")
+        assert.equal(elem.getAttribute("type"), "hidden");
+        assert.equal(elemString(elem), "<input type=\"hidden\" />")
+        assert.end()
+    })
+
     test("can set and get attributes", function (assert) {
         var elem = document.createElement("div")
         assert.equal(elem.getAttribute("foo"), null)