-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve by=<non-ASCII> test to be more robust #6573
Comments
@nunotexbsd, can you help to come up with an example of running |
Following example on #4708:
Did try variants like month==mês and it works fine too. I didn't apply this patch yet to check testunit. EDIT: execute |
R requires symbols to exist in the native encoding, so trying to construct a call to The real underlying problem of #4708 is that for |
Hmm, so @nunotexbsd what happens for this example then? dt <- data.table(a=1:3,año=c(2020,2021,2023), `a?o` = 4:6)
dt[,sum(a), by=año] |
I think that @nunotexbsd is running interactive examples in the
"C.UTF-8" locale (where everything works) but unit tests in the "C"
locale (where enc2native('año') returns 'a?o').
|
|
Originally posted by @MichaelChirico in #6567 (comment)
As reported in #6559, the test will not run on FreeBSD. We should come up with an example that will test non-ASCII
by=
on such systems.The text was updated successfully, but these errors were encountered: