Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added freadR.c to Documentation for OpenMP Directives #6162

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

Nj221102
Copy link
Contributor

This PR addresses issue #5265 by adding the missing freadR.c file to the list of files in the data.table/man/openmp-utils.Rd documentation that contain OpenMP directives.

Changes:

  • Added an entry for freadR.c in the data.table/man/openmp-utils.Rd file to document that it contains OpenMP directives associated with the fread function.

This update ensures that all relevant files with OpenMP directives are accurately documented.

closes #5265

@tdhock
Copy link
Member

tdhock commented Jun 1, 2024

is this compatible with #6018 ? @Anirban166 please review

@Anirban166
Copy link
Member

is this compatible with #6018 ? @Anirban166 please review

If you meant merge conflicts then it isn't an issue for me since its a really minor change and I can have it added in my PR, although I'll need to investigate and write about freadR.c then.

(As for #6018 I'm waiting for someone to review what I wrote so the other route would be to wait till that gets merged and then we can merge this)

@MichaelChirico
Copy link
Member

Thanks!

@MichaelChirico MichaelChirico merged commit d6a9fe7 into master Sep 3, 2024
7 checks passed
@MichaelChirico MichaelChirico deleted the openmp-doc branch September 3, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

openmp documentation misses freadR.c file
4 participants