Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add clang-tidy to GLCI #6580

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+1 −0
Open

add clang-tidy to GLCI #6580

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
74d042a
add clang tidy
ben-schwen Oct 18, 2024
421cffd
use clang-tidy readability
ben-schwen Oct 18, 2024
799f921
use c99 standard
ben-schwen Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitlab-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,7 @@ test-lin-dev-clang-cran:
- echo 'CFLAGS=-g -O2 -fno-common -Wall -Wvla -pedantic -fstack-protector-strong -D_FORTIFY_SOURCE=2' > ~/.R/Makevars
- echo 'CXXFLAGS=-g -O2 -fno-common -Wall -Wvla -pedantic -fstack-protector-strong -D_FORTIFY_SOURCE=2' >> ~/.R/Makevars
- *install-deps
- clang-tidy -extra-arg=-I/usr/local/lib/R/include -checks='readability-inconsistent-declaration-parameter' src/*.c -- -std=c11
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what will this look like for manually specifying, say, dozens of checks? Will it just be

clang-tidy -extra-arg=... \
  -checks='...' \
  src/*.c

Is it possible to keep this as a list in a file (say in .ci)?

(doesn't need to be done in this PR since we only have one check thus far, just trying to think ahead before it gets much harder to refactor)

Copy link
Member Author

@ben-schwen ben-schwen Oct 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. We can also use globbing for checks e.g. -check='readability-*' or multiple checks with -checks='bugprone-*,readability-*'

- R CMD check --as-cran $(ls -1t data.table_*.tar.gz | head -n 1)
- (! grep "warning:" data.table.Rcheck/00install.out)
- >-
Expand Down
Loading