Minor optimizations and improvements #173
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
UnspecifiedConstraints
and simply usesConstraints
(UnspecifiedConstraints
is aconst
now)BetheFactorization
and simply usesUnspecifiedConstraints
MeanField
, that it does not respectdefault_constraint
BitSet
matrices (checked on a simple model on RxInfer)Note: Benchmarks show that
getorcreate!
is significantly slower (and only in case of1
), I don't believe it and it seems like a noise. I didn't touch this part of the code, so it should not become slower or faster.Would be nice if you could double check it @wouterwln