2.x: PublishSubject enhance NPE when onNext(null) is called (#4531)

vanniktech · akarnokd · commit a588c66271c8 · 2016-09-12T13:49:48.000+02:00
diff --git a/src/main/java/io/reactivex/subjects/PublishSubject.java b/src/main/java/io/reactivex/subjects/PublishSubject.java
@@ -176,7 +176,7 @@ public void onNext(T t) {
             return;
         }
         if (t == null) {
-            onError(new NullPointerException());
+            onError(new NullPointerException("Subject got a null value. Null values are generally not allowed in 2.x operators and sources."));
             return;
         }
         for (PublishDisposable<T> s : subscribers.get()) {

Original file line number	Diff line number	Diff line change
`@@ -176,7 +176,7 @@ public void onNext(T t) {`
`176`	`176`	`return;`
`177`	`177`	`}`
`178`	`178`	`if (t == null) {`
`179`		`- onError(new NullPointerException());`
	`179`	`+ onError(new NullPointerException("Subject got a null value. Null values are generally not allowed in 2.x operators and sources."));`
`180`	`180`	`return;`
`181`	`181`	`}`
`182`	`182`	`for (PublishDisposable<T> s : subscribers.get()) {`