From 4c6ce9e4b122a2deeab3c876f92b5f15ab1b439d Mon Sep 17 00:00:00 2001 From: OJ Kwon Date: Sun, 22 Oct 2017 18:54:52 -0700 Subject: [PATCH 1/2] chore(danger): update rules --- dangerfile.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dangerfile.js b/dangerfile.js index fa43dd86..9f1b451e 100644 --- a/dangerfile.js +++ b/dangerfile.js @@ -39,6 +39,6 @@ const messageConventionValid = danger.git.commits.reduce(function (acc, value) { }, true); if (!messageConventionValid) { - warn('commit message does not follows conventional change log (' + ++errorCount + ')'); + fail('commit message does not follows conventional change log (' + ++errorCount + ')'); markdown('> (' + errorCount + ') : RxJS uses conventional change log to generate changelog automatically. It seems some of commit messages are not following those, please check [contributing guideline](https://github.com/ReactiveX/rxjs/blob/master/CONTRIBUTING.md#commit-message-format) and update commit messages.'); } \ No newline at end of file From 626fa7dc61d9a66a51bbb61da03aae414d88d253 Mon Sep 17 00:00:00 2001 From: OJ Kwon Date: Sun, 22 Oct 2017 18:55:02 -0700 Subject: [PATCH 2/2] chore(travis): update build coverage config --- .travis.yml | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/.travis.yml b/.travis.yml index 0f195395..f96b4db0 100644 --- a/.travis.yml +++ b/.travis.yml @@ -24,8 +24,8 @@ before_install: script: - if [ -n "DANGER_GITHUB_API_TOKEN" ]; then echo {} > ./.babelrc && npx danger; fi - ng lint - - ng test --single-run - - ng build -prod + - ng test --single-run --code-coverage + - ng build --prod - ng e2e before_deploy: @@ -37,4 +37,7 @@ before_deploy: deploy: provider: azure_web_apps verbose: true - skip_cleanup: true \ No newline at end of file + skip_cleanup: true + +after_success: + - bash <(curl -s https://codecov.io/bash)