From 0bda9cd2936239eeafc475c3c4d2afdf568ea396 Mon Sep 17 00:00:00 2001 From: Mattias Holmlund Date: Sat, 26 May 2018 00:16:19 +0200 Subject: [PATCH] fix(typings): allow bufferCreationInterval null for bufferTime (#3734) * fix(typings): allow bufferCreationInterval null for bufferTime The tests for bufferTime verifies that it is possible to set bufferCreationInterval to null, but the typings did not allow it when strictNullChecks were set to true. Fixes #3728 * fix(typings): allow bufferCreationInterval undefined for bufferTime --- compat/operator/bufferTime.ts | 4 ++-- src/internal/operators/bufferTime.ts | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/compat/operator/bufferTime.ts b/compat/operator/bufferTime.ts index c980ef627f..44662e7c00 100644 --- a/compat/operator/bufferTime.ts +++ b/compat/operator/bufferTime.ts @@ -4,8 +4,8 @@ import { bufferTime as higherOrder } from 'rxjs/operators'; /* tslint:disable:max-line-length */ export function bufferTime(this: Observable, bufferTimeSpan: number, scheduler?: SchedulerLike): Observable; -export function bufferTime(this: Observable, bufferTimeSpan: number, bufferCreationInterval: number, scheduler?: SchedulerLike): Observable; -export function bufferTime(this: Observable, bufferTimeSpan: number, bufferCreationInterval: number, maxBufferSize: number, scheduler?: SchedulerLike): Observable; +export function bufferTime(this: Observable, bufferTimeSpan: number, bufferCreationInterval: number | null | undefined, scheduler?: SchedulerLike): Observable; +export function bufferTime(this: Observable, bufferTimeSpan: number, bufferCreationInterval: number | null | undefined, maxBufferSize: number, scheduler?: SchedulerLike): Observable; /* tslint:enable:max-line-length */ /** diff --git a/src/internal/operators/bufferTime.ts b/src/internal/operators/bufferTime.ts index 11f9205cc3..1012862ee3 100644 --- a/src/internal/operators/bufferTime.ts +++ b/src/internal/operators/bufferTime.ts @@ -8,8 +8,8 @@ import { OperatorFunction, SchedulerAction, SchedulerLike } from '../types'; /* tslint:disable:max-line-length */ export function bufferTime(bufferTimeSpan: number, scheduler?: SchedulerLike): OperatorFunction; -export function bufferTime(bufferTimeSpan: number, bufferCreationInterval: number, scheduler?: SchedulerLike): OperatorFunction; -export function bufferTime(bufferTimeSpan: number, bufferCreationInterval: number, maxBufferSize: number, scheduler?: SchedulerLike): OperatorFunction; +export function bufferTime(bufferTimeSpan: number, bufferCreationInterval: number | null | undefined, scheduler?: SchedulerLike): OperatorFunction; +export function bufferTime(bufferTimeSpan: number, bufferCreationInterval: number | null | undefined, maxBufferSize: number, scheduler?: SchedulerLike): OperatorFunction; /* tslint:enable:max-line-length */ /**