fix(ReplaySubject): don't buffer next if stopped (#5696)

* test(ReplaySubject): add failing tests

* fix(ReplaySubject): don't buffer next if stopped

* chore: remove VSCode-added lodash import

Oh, FFS, now I've done it.

ajax/package.json

@@ -0,0 +1,8 @@
+{
+  "name": "rxjs/ajax",
+  "typings": "../dist/types/ajax/index.d.ts",
+  "main": "../dist/cjs/ajax/index.js",
+  "module": "../dist/esm5/ajax/index.js",
+  "es2015": "../dist/esm/ajax/index.js",
+  "sideEffects": false
+}

fetch/package.json

@@ -0,0 +1,8 @@
+{
+  "name": "rxjs/fetch",
+  "typings": "../dist/types/fetch/index.d.ts",
+  "main": "../dist/cjs/fetch/index.js",
+  "module": "../dist/esm5/fetch/index.js",
+  "es2015": "../dist/esm/fetch/index.js",
+  "sideEffects": false
+}

operators/package.json

@@ -0,0 +1,8 @@
+{
+  "name": "rxjs/operators",
+  "typings": "../dist/types/operators/index.d.ts",
+  "main": "../dist/cjs/operators/index.js",
+  "module": "../dist/esm5/operators/index.js",
+  "es2015": "../dist/esm/operators/index.js",
+  "sideEffects": false
+}

spec/subjects/ReplaySubject-spec.ts

@@ -267,4 +267,32 @@ describe('ReplaySubject', () => {
 
     expect(results).to.deep.equal([3, 4, 5, 'done']);
   });
+
+  it('should not buffer nexted values after complete', () => {
+    const results: (number | string)[] = [];
+    const subject = new ReplaySubject<number>();
+    subject.next(1);
+    subject.next(2);
+    subject.complete();
+    subject.next(3);
+    subject.subscribe({
+      next: value => results.push(value),
+      complete: () => results.push('C'),
+    });
+    expect(results).to.deep.equal([1, 2, 'C']);
+  });
+
+  it('should not buffer nexted values after error', () => {
+    const results: (number | string)[] = [];
+    const subject = new ReplaySubject<number>();
+    subject.next(1);
+    subject.next(2);
+    subject.error(new Error('Boom!'));
+    subject.next(3);
+    subject.subscribe({
+      next: value => results.push(value),
+      error: () => results.push('E'),
+    });
+    expect(results).to.deep.equal([1, 2, 'E']);
+  });
 });

src/internal/ReplaySubject.ts

@@ -35,21 +35,23 @@ export class ReplaySubject<T> extends Subject<T> {
   }
 
   private nextInfiniteTimeWindow(value: T): void {
-    const _events = this._events;
-    _events.push(value);
-    // Since this method is invoked in every next() call than the buffer
-    // can overgrow the max size only by one item
-    if (_events.length > this._bufferSize) {
-      _events.shift();
+    if (!this.isStopped) {
+      const _events = this._events;
+      _events.push(value);
+      // Since this method is invoked in every next() call than the buffer
+      // can overgrow the max size only by one item
+      if (_events.length > this._bufferSize) {
+        _events.shift();
+      }
     }
-
     super.next(value);
   }
 
   private nextTimeWindow(value: T): void {
-    this._events.push(new ReplayEvent(this._getNow(), value));
-    this._trimBufferThenGetEvents();
-
+    if (!this.isStopped) {
+      this._events.push(new ReplayEvent(this._getNow(), value));
+      this._trimBufferThenGetEvents();
+    }
     super.next(value);
   }
 

testing/package.json

@@ -0,0 +1,8 @@
+{
+  "name": "rxjs/testing",
+  "typings": "../dist/types/testing/index.d.ts",
+  "main": "../dist/cjs/testing/index.js",
+  "module": "../dist/esm5/testing/index.js",
+  "es2015": "../dist/esm/testing/index.js",
+  "sideEffects": false
+}

webSocket/package.json

@@ -0,0 +1,8 @@
+{
+  "name": "rxjs/webSocket",
+  "typings": "../dist/types/webSocket/index.d.ts",
+  "main": "../dist/cjs/webSocket/index.js",
+  "module": "../dist/esm5/webSocket/index.js",
+  "es2015": "../dist/esm/webSocket/index.js",
+  "sideEffects": false
+}