Skip to content

Commit

Permalink
fix(Subject): lift signature is now appropriate for stricter TypeScri…
Browse files Browse the repository at this point in the history
…pt 2.4 checks

Type safety wasn't really gauranteed with lift before because we survived for a long time with an incorrect type signature, TypeScript 2.4 introduces stricter type-checking, and all of a sudden `lift` on `Subject` was breaking builds for those that are riding the wave of the latest-and-greatest.
  • Loading branch information
benlesh committed Jul 5, 2017
1 parent 3bb6240 commit 8ed7054
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/Subject.ts
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ export class Subject<T> extends Observable<T> implements ISubscription {
return new AnonymousSubject<T>(destination, source);
}

lift<R>(operator: Operator<T, R>): Observable<T> {
lift<R>(operator: Operator<T, R>): Observable<R> {
const subject = new AnonymousSubject(this, this);
subject.operator = <any>operator;
return <any>subject;
Expand Down

0 comments on commit 8ed7054

Please sign in to comment.