Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zipWith implementation needs investigated #5571

Closed
benlesh opened this issue Jul 4, 2020 · 1 comment
Closed

zipWith implementation needs investigated #5571

benlesh opened this issue Jul 4, 2020 · 1 comment
Assignees

Comments

@benlesh
Copy link
Member

benlesh commented Jul 4, 2020

We're currently doing something strange with zipWith (aka the "zip operator"), where we're essentially creating a new observable with the static zip, then creating a new "blank Observable", and setting the source property to the zip, but never setting the operator property.

This seems very unusual, and I feel there are probably bugs around this, and/or it could just be refactored to something simpler.

This apparently also exists in the raceWith operator.

@benlesh benlesh assigned benlesh and cartant and unassigned benlesh Jul 4, 2020
@benlesh
Copy link
Member Author

benlesh commented Jul 4, 2020

I see why it's doing this. And it is just another smell related to lift. I can't imagine an end user thinking they need to implement an operator from a static method like this. Related to #5431

Closing for now.

@benlesh benlesh closed this as completed Jul 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants