Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check API guardian in against a single version of TS #5608

Closed
cartant opened this issue Jul 28, 2020 · 3 comments
Closed

Check API guardian in against a single version of TS #5608

cartant opened this issue Jul 28, 2020 · 3 comments

Comments

@cartant
Copy link
Collaborator

cartant commented Jul 28, 2020

Bug Report

It seems that API guardian cannot be made to work with all version combinations. We should pick a single version and perform the API guardian checks with that version only. IMO, it the checks should be run against whatever the version in master are using.

The problem is highlighted here:

api-guardian

Note that between versions, the union in the return type is either 0 | 1 | -1 or 1 | 0 | -1.

failures

@cartant
Copy link
Collaborator Author

cartant commented Jul 28, 2020

FWIW, I've not looked into this, so whether or not it's the TS version or the version of the Node types, IDK.

@kwonoj
Copy link
Member

kwonoj commented Jul 28, 2020

fyi, our gh action have pinned ts version and ts@latest action doesn't run api_guardian, so there's no combination for ts version across CI. (plus we don't have different @types/node across CI even? https://github.com/ReactiveX/rxjs/blob/master/package.json#L105)

@cartant
Copy link
Collaborator Author

cartant commented Jul 30, 2020

It seems the problem was that I needed to recompile. Regarding what it was between compiles that effected the different output ... 🤷‍♂️

@cartant cartant closed this as completed Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants