fix(bindNodeCallback): emit undefined when callback has no success ar… #2329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…guments Emit undefined insteady of empty array by resulting Observable, when callback function is called without success parameters. Closes #2254
kwonoj
reviewed
Feb 6, 2017
|
|
||
| boundCallback() | ||
| .subscribe((x: any) => { | ||
| results.push(typeof x); |
There was a problem hiding this comment.
just curiosity, is there reason to push type instead of actual value to assert with undefined directly?
There was a problem hiding this comment.
I guess just habit of "everyone can set undefined value, so never trust it". All JS resources used to be very paranoid when I was learning. ;)
jayphelps
approved these changes
Feb 14, 2017
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently when callback is called without success arguments (second and following arguments),
bindNodeCallbackemits empty array.In RxJS 4
undefinedis emitted instead as can be seen here:https://github.com/Reactive-Extensions/RxJS/blob/master/src/core/perf/operators/fromnodecallback.js#L23-L24
(when results array is empty
results[0]returnsundefinedwhich is then emitted)Related issue (if exists):
Related issue with
bindCallback#2328Closes #2254