Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leading/Trailing throttle and throttleTime configuration #2465

Merged
merged 3 commits into from
May 9, 2017
Merged

Leading/Trailing throttle and throttleTime configuration #2465

merged 3 commits into from
May 9, 2017

Commits on Mar 15, 2017

  1. feat(throttle): add leading/trailing configurability 

    Adds the ability to configure the `throttle` operator via a
configuration object in the same manner as Lodash's throttle.

Currently this defaults to the existing behavior, which is `{ leading:
true, trailing: false }`. In an upcoming major version, I think we
should change this to align with other libraries that have similar
functionality. In particular Lodash, given it's popularity.

NOTE: While working on this I discovered that the leading value is
actually being emitted *after* the durationSelector is called and
subscribed to. This is likely a bug, but I'll file a separate issue.

related #1625
    Benjamin Lesh committed Mar 15, 2017
    Configuration menu
    Copy the full SHA
    ecba82d View commit details
    Browse the repository at this point in the history

  2. feat(throttleTime): add leading/trailing configurability 

    resolves #1625
    Benjamin Lesh committed Mar 15, 2017
    Configuration menu
    Copy the full SHA
    437a5db View commit details
    Browse the repository at this point in the history

  3. chore(throttle/throttleTime-spec): fix diagram text

    Benjamin Lesh committed Mar 15, 2017
    Configuration menu
    Copy the full SHA
    c610e35 View commit details
    Browse the repository at this point in the history