Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(elementAt): force unsubscribe when it completes or errors" #2664

Merged
merged 1 commit into from
Jun 14, 2017

Conversation

benlesh
Copy link
Member

@benlesh benlesh commented Jun 14, 2017

Reverts #2501

Damnit... this is the SECOND TIME I've done this. @mpodlasin, do you think you can rename your PRs that are similar to this from fix() to NEXT MAJOR fix()? So sorry. You'll need to resubmit the one for this and the one for find

@rxjs-bot
Copy link

Warnings
⚠️ commit message does not follows conventional change log (1)

(1) : RxJS uses conventional change log to generate changelog automatically. It seems some of commit messages are not following those, please check contributing guideline and update commit messages.

Generated by 🚫 dangerJS

@coveralls
Copy link

coveralls commented Jun 14, 2017

Coverage Status

Coverage decreased (-0.001%) to 97.736% when pulling 1e126eb on revert-2501-element-at-switch-map-fix into a400cab on master.

@kwonoj
Copy link
Member

kwonoj commented Jun 14, 2017

@benlesh I can make danger to block merge to master if PR's labeled as major. (by failing checker). If you're interested, will create PR.

@benlesh
Copy link
Member Author

benlesh commented Jun 14, 2017

@kwonoj sure, why not? Really, we should just always have those PRs target a branch for major... we have some refactoring to do WRT our publishing and branching practices.

@benlesh benlesh merged commit 97ce813 into master Jun 14, 2017
@kwonoj
Copy link
Member

kwonoj commented Jun 14, 2017

@benlesh yes, once we have branch policy that'd way to go.

@kwonoj kwonoj deleted the revert-2501-element-at-switch-map-fix branch June 14, 2017 20:30
@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants