Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove useless import #4787

Merged
merged 1 commit into from
May 16, 2019
Merged

Conversation

cartant
Copy link
Collaborator

@cartant cartant commented May 16, 2019

Description:

This PR removes a useless import - that appears to have been added by VS Code's autocomplete/autoimport feature.

Related issue (if exists): None

@cartant cartant requested a review from benlesh May 16, 2019 01:10
@kwonoj
Copy link
Member

kwonoj commented May 16, 2019

Thought we had tslint or compiler for unused import.

@benlesh benlesh merged commit fc9186c into ReactiveX:master May 16, 2019
@cartant
Copy link
Collaborator Author

cartant commented May 16, 2019

@kwonoj The in-built TSLint rule for unused imports is hugely problematic. There is a rule in tslint-etc that does a better job. If you want that enabled, I can submit a PR.

For reference - re: the TSLint rule - see my comment here.

@kwonoj
Copy link
Member

kwonoj commented May 16, 2019

This kind of things can benefit from tools obviously, so I'm in for it if you're ok.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 15, 2019
@cartant cartant deleted the remove-util-import branch September 24, 2020 07:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants