docs(operators): fixed references to marble diagrams #4934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claasahl
changed the title
claasahl
changed the title
claasahl
changed the title
niklas-wortmann
requested changes
Jul 30, 2019
src/internal/observable/pairs.ts
Outdated
| @@ -8,7 +8,7 @@ import { Subscription } from '../Subscription'; | |||
| * | |||
| * <span class="informal">Turn entries of an object into a stream.</span> | |||
| * | |||
| * <img src="./img/pairs.png" width="100%"> | |||
| * <img src="/assets/images/marble-diagrams/pairs.png" width="100%"> | |||
There was a problem hiding this comment.
This should be changed to just 'pairs', similar to like you did for tap
niklas-wortmann
requested changes
Jul 31, 2019
src/internal/observable/pairs.ts
Outdated
| @@ -8,7 +8,7 @@ import { Subscription } from '../Subscription'; | |||
| * | |||
| * <span class="informal">Turn entries of an object into a stream.</span> | |||
| * | |||
| * <img src="./img/pairs.png" width="100%"> | |||
| * <img src="pairs.png" width="100%"> | |||
There was a problem hiding this comment.
I'm really sorry, I didn't expressed well.
It should be like this:
There was a problem hiding this comment.
makes sense. done.
There was a problem hiding this comment.
I came across another img-tag in the generate operator
niklas-wortmann
approved these changes
Jul 31, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Noticed that the documentation for
tapreferences a missing marble diagram.Related issue (if exists):
n/a