4776 add doc ur ls to deprecation messages #5128

BioPhoton · 2019-11-07T02:42:53Z

WORK IN PROGRESS

Related to #4776

Migration-Timeline

The migration timeline is here to support you in the following things:

Core Features

Getting a detailed explanation on why a deprecation happened (reason)
Elaborating the different between the deprecated version and the new version (implications)
- Code examples of the deprecated and the new version
Linking and navigation on release level as well as on item level "deep-link-able"

Optional Features (after core features are done)

Missing migration items resolves in a suggestion to open an issue.
- If deprecation information does not exist suggest to open an issue.
- Implement Link to docs issue template
- Use pre-fill options to suggest useful issue content
Migration over compat-layer
Migration over tooling
Manual Migration suggestions i.e. what happened in this relese e.g. import path changes

Other Infos:

Current Progress

UI

Create navigation bar for releases
Create list of releases
- Create Release UI element
- Create list of deprecations
  - Create Deprecation UI element
- Create list of breaking changes
  - Create BreakingChange UI element

Functionality

Decide on data structure
- Implement server to client store parser and formatter
- Implement client store to view parser and formatter
Decide on navigation strategy
- Implement navigation to deprecation release
- Implement navigation to deprecation item
Decide on how to deal with "release panel open" state

Data
Code:

Deprecation
- Ensure breakingChange exists if not autogenerate
BreakigChange
- Ensure breakingChange MID fields reuse MID fields from related deprecation

Data

Manual work:

Release

version: Check tag
date: Find version on npm. Inspect HTML to get date
Examples for estimated dates:
- YYYY
- YYYY-MM
- YYYY-MM-DD

Deprecation

subject, subjectApiSymbol, subjectAction: Align with others
sourceLink: branch and loc correct
deprecationMsgCode: check Nicolas suggestions here
reason: Can be a lill more wordy than deprecationMsgCode
implication: Code description to spot the difference
exampleBefore, exampleAfter see interface docs

MOVE
Due to folder structure changes from v5 to v6 I have to move several results from here:
https://github.com/search?utf8=%E2%9C%93&q=%5C%40deprecated+repo%3AReactiveX%2Frxjs+created%3A%22%3C2018-04-11%22+repo%3AReactiveX%2Frxjs%2Ftree%2F5.x+path%3A%2Fsrc&type=Code&ref=advsearch&l=&l=

Edge Cases to clarify

missing deprecation https://github.com/ReactiveX/rxjs/blob/6.5.3/src/internal/operators/switchMap.ts#L84
Deprecation not documented see 6.0.0-alpha.3 vs 6.0.0-alpha.2 => coulb be inserted when updating the migration messages
deprecation rollback e.g. observer object vs callbacks
feature introduction and deprecation at the same time e.g. resultSelector of fromEventPattern
Deprecations introduced after the change e.g. Observable.if should be deprecated from 5.5.x on but got deprecated in 6.0.0-rc.1
Breaking change without deprecation

First Draft

cartant · 2019-11-17T21:09:19Z

docs_app/src/app/custom-elements/migration-timeline/data-access/migration-timeline.ts

+        `
+      },
+      {
+        subject: 'combineLatest',


Regarding the 'implication', I think it should be an explanation that accompanies the 'before deprecation' and 'after deprecation' snippets. That is, it should explain what's different between the two so that users don't have to try to spot the differences themselves.

Reason

The reason doesn't seem quite right, to me.

My understanding is not that scheduling is going to be released as a separate package, rather that it is only going to be used where appropriate.

ATM, there are signatures all over the place that include optional scheduler parameters.

The means that the implementation needs to check for a scheduler, etc., which references/imports the scheduling and prevents it from being tree-shaken.

Implication

I would say something like:

For combineLatest, the removal of the scheduler parameter means that if callers want notifications to be scheduled, they will have to use observeOn.

Before Deprecation

import { combineLatest, asyncScheduler } from "rxjs"; combineLatest(a$, b$, asyncScheduler).subscribe({ next: ([a, b]) => console.log(a, b) });

After Deprecation

import { combineLatest, asyncScheduler, observeOn } from "rxjs"; combineLatest(a$, b$).pipe( observeOn(asyncScheduler) ).subscribe({ next: ([a, b]) => console.log(a, b) });

cartant · 2019-11-18T03:18:34Z

My thoughts on making the deprecation messages less wordy and easier to interpret in linter output. Whether or not it's worth losing the link stuff to make said output easier on the eye - at the expense of losing the links in the docs, IDK. Maybe.

Also, the linter output really needs to be accompanied by a URL that takes users to the relevant deprecation information in the docs. IMO, code examples, etc. should be moved there and out of the messages. Similarly, I don't think there is any need for the message to say when something is going to be removed, etc. The messages should be as plain and direct as possible, IMO, and should link to the docs.

Thoughts below are arranged as:

[link to deprecation]
[current message]
[what I think the message should be]

rxjs/src/internal/observable/never.ts

Line 37 in 41888ef

* @deprecated Deprecated in favor of using {@link NEVER} constant.

Deprecated in favor of using {@link NEVER} constant.
use the NEVER constant instead

rxjs/src/internal/observable/empty.ts

Line 60 in 69f7c6d

    
            * @deprecated Deprecated in favor of using {@link index/EMPTY} constant, or {@link scheduled} (e.g. `scheduled([], scheduler)`)

Deprecated in favor of using {@link index/EMPTY} constant, or {@link scheduled} (e.g. `scheduled([], scheduler)`)
use the EMPTY constant or scheduled([], scheduler) instead

rxjs/src/internal/observable/dom/WebSocketSubject.ts

Line 105 in f5e143d

/** @deprecated use {@link deserializer} */

use {@link deserializer}
use deserializer instead

rxjs/src/internal/operators/combineLatest.ts

Line 42 in 8fbb15e

* @deprecated Deprecated in favor of static {@link combineLatest}.

Deprecated in favor of static {@link combineLatest}.
use the static combineLatest instead

rxjs/src/internal/operators/merge.ts

Line 37 in 8fbb15e

* @deprecated Deprecated in favor of static {@link merge}.

Deprecated in favor of static {@link merge}.
use the static merge instead

rxjs/src/internal/operators/zip.ts

Line 37 in 8fbb15e

* @deprecated Deprecated in favor of static {@link zip}.

Deprecated in favor of static {@link zip}.
use the static zip instead

rxjs/src/internal/operators/concat.ts

Line 25 in 56cbd22

* @deprecated Deprecated in favor of static {@link concat}.

Deprecated in favor of static {@link concat}.
use the static concat instead

rxjs/src/internal/operators/concatMapTo.ts

Line 8 in 41888ef

/** @deprecated */

-
use the map operator instead of a result selector

rxjs/src/internal/operators/mergeMapTo.ts

Line 7 in 26e16d7

/** @deprecated */

-
use the map operator instead of a result selector

rxjs/src/internal/observable/zip.ts

Line 37 in 56cbd22

/** @deprecated resultSelector is no longer supported, pipe to map instead */

resultSelector is no longer supported, pipe to map instead
use the map operator instead of a result selector

rxjs/src/internal/operators/switchMapTo.ts

Line 8 in 26e16d7

    
           /** @deprecated resultSelector is no longer supported. Switch to using switchMap with an inner map */

resultSelector is no longer supported. Switch to using switchMap with an inner map
use the map operator, on the inner observable, instead of a result selector

rxjs/src/internal/operators/concatMap.ts

Line 8 in 41888ef

/** @deprecated resultSelector no longer supported, use inner map instead */

resultSelector no longer supported, use inner map instead
use the map operator, on the inner observable, instead of a result selector

rxjs/src/internal/operators/mergeMap.ts

Line 16 in 41888ef

/** @deprecated resultSelector no longer supported, use inner map instead */

resultSelector no longer supported, use inner map instead
use the map operator, on the inner observable, instead of a result selector

rxjs/src/internal/operators/exhaustMap.ts

Line 16 in 59b5d82

    
           /** @deprecated resultSelector is no longer supported. Use inner map instead. */

resultSelector is no longer supported. Use inner map instead.
use the map operator, on the inner observable, instead of a result selector

rxjs/src/internal/operators/switchMap.ts

Line 16 in ab49acc

/** @deprecated resultSelector is no longer supported, use inner map instead */

resultSelector is no longer supported, use inner map instead
use the map operator, on the inner observable, instead of a result selector

rxjs/src/internal/observable/fromEvent.ts

Line 54 in e5ab37d

/** @deprecated resultSelector no longer supported, pipe to map instead */

resultSelector no longer supported, pipe to map instead
use the map operator instead of a result selector

rxjs/src/internal/observable/fromEventPattern.ts

Line 9 in 41888ef

/** @deprecated resultSelector no longer supported, pipe to map instead */

resultSelector no longer supported, pipe to map instead
use the map operator instead of a result selector

rxjs/src/internal/observable/bindNodeCallback.ts

Line 11 in 41888ef

/** @deprecated resultSelector is deprecated, pipe to map instead */

resultSelector is deprecated, pipe to map instead
use the map operator instead of a result selector

rxjs/src/internal/observable/bindCallback.ts

Line 11 in 056158d

    
           /** @deprecated resultSelector is no longer supported, use a mapping function. */

resultSelector is no longer supported, use a mapping function.
use the map operator instead of a result selector

rxjs/src/internal/observable/forkJoin.ts

Line 40 in 7926122

/** @deprecated resultSelector is deprecated, pipe to map instead */

resultSelector is deprecated, pipe to map instead
use the map operator instead of a result selector

rxjs/src/internal/Scheduler.ts

Line 20 in 01a0978

* @deprecated Scheduler is an internal implementation detail of RxJS, and

Scheduler is an internal implementation detail of RxJS, and should not be used directly. Rather, create your own class and implement SchedulerLike
internal use only - create your own class and implement SchedulerLike instead

https://github.com/ReactiveX/rxjs/blob/6.0.0-rc.1/src/internal/Observable.ts#L260

In favor of iif creation function: import { iif } from 'rxjs';
renamed - use iif instead

https://github.com/ReactiveX/rxjs/blob/6.0.0-rc.1/src/internal/Observable.ts#L265

In favor of throwError creation function: import { throwError } from 'rxjs';
renamed - use throwError instead

rxjs/src/internal/operators/race.ts

Line 24 in 8f7d7fb

* @deprecated Deprecated in favor of static {@link race}.

Deprecated in favor of static {@link race}.
use the static race instead

https://github.com/ReactiveX/rxjs/blob/6.4.0/src/internal/Observable.ts#L74

Use an observer instead of a complete callback
use an observer instead of separate callbacks

https://github.com/ReactiveX/rxjs/blob/6.4.0/src/internal/Observable.ts#L76

Use an observer instead of a error callback
use an observer instead of separate callbacks

https://github.com/ReactiveX/rxjs/blob/6.4.0/src/internal/Observable.ts#L78

Use an observer instead of a complete callback
use an observer instead of separate callbacks

https://github.com/ReactiveX/rxjs/blob/6.4.0/src/internal/operators/tap.ts#L9

Use an observer instead of a complete callback
use an observer instead of separate callbacks

https://github.com/ReactiveX/rxjs/blob/6.4.0/src/internal/operators/tap.ts#L11

Use an observer instead of a error callback
use an observer instead of separate callbacks

https://github.com/ReactiveX/rxjs/blob/6.4.0/src/internal/operators/tap.ts#L13

Use an observer instead of a complete callback
use an observer instead of separate callbacks

https://github.com/ReactiveX/rxjs/blob/6.4.0/src/internal/Observable.ts#L53

use new Observable() instead
use new Observable() instead

https://github.com/ReactiveX/rxjs/blob/6.4.0/src/internal/operators/timeInterval.ts#L70

exposed API, use as interface only.
// This is a TODO. Ignore this for now. The deprecation isn't useful ATM.

https://github.com/ReactiveX/rxjs/blob/6.3.0/src/internal/types.ts#L49

use {@link InteropObservable }
use InteropObservable instead

rxjs/src/internal/observable/combineLatest.ts

Lines 17 to 30 in 95bd807

    
           /** @deprecated resultSelector no longer supported, pipe to map instead */ 
        
           export function combineLatest<O1 extends ObservableInput<any>, R>(sources: [O1], resultSelector: (v1: ObservedValueOf<O1>) => R, scheduler?: SchedulerLike): Observable<R>; 
        
           /** @deprecated resultSelector no longer supported, pipe to map instead */ 
        
           export function combineLatest<O1 extends ObservableInput<any>, O2 extends ObservableInput<any>, R>(sources: [O1, O2], resultSelector: (v1: ObservedValueOf<O1>, v2: ObservedValueOf<O2>) => R, scheduler?: SchedulerLike): Observable<R>; 
        
           /** @deprecated resultSelector no longer supported, pipe to map instead */ 
        
           export function combineLatest<O1 extends ObservableInput<any>, O2 extends ObservableInput<any>, O3 extends ObservableInput<any>, R>(sources: [O1, O2, O3], resultSelector: (v1: ObservedValueOf<O1>, v2: ObservedValueOf<O2>, v3: ObservedValueOf<O3>) => R, scheduler?: SchedulerLike): Observable<R>; 
        
           /** @deprecated resultSelector no longer supported, pipe to map instead */ 
        
           export function combineLatest<O1 extends ObservableInput<any>, O2 extends ObservableInput<any>, O3 extends ObservableInput<any>, O4 extends ObservableInput<any>, R>(sources: [O1, O2, O3, O4], resultSelector: (v1: ObservedValueOf<O1>, v2: ObservedValueOf<O2>, v3: ObservedValueOf<O3>, v4: ObservedValueOf<O4>) => R, scheduler?: SchedulerLike): Observable<R>; 
        
           /** @deprecated resultSelector no longer supported, pipe to map instead */ 
        
           export function combineLatest<O1 extends ObservableInput<any>, O2 extends ObservableInput<any>, O3 extends ObservableInput<any>, O4 extends ObservableInput<any>, O5 extends ObservableInput<any>, R>(sources: [O1, O2, O3, O4, O5], resultSelector: (v1: ObservedValueOf<O1>, v2: ObservedValueOf<O2>, v3: ObservedValueOf<O3>, v4: ObservedValueOf<O4>, v5: ObservedValueOf<O5>) => R, scheduler?: SchedulerLike): Observable<R>; 
        
           /** @deprecated resultSelector no longer supported, pipe to map instead */ 
        
           export function combineLatest<O1 extends ObservableInput<any>, O2 extends ObservableInput<any>, O3 extends ObservableInput<any>, O4 extends ObservableInput<any>, O5 extends ObservableInput<any>, O6 extends ObservableInput<any>, R>(sources: [O1, O2, O3, O4, O5, O6], resultSelector: (v1: ObservedValueOf<O1>, v2: ObservedValueOf<O2>, v3: ObservedValueOf<O3>, v4: ObservedValueOf<O4>, v5: ObservedValueOf<O5>, v6: ObservedValueOf<O6>) => R, scheduler?: SchedulerLike): Observable<R>; 
        
           /** @deprecated resultSelector no longer supported, pipe to map instead */ 
        
           export function combineLatest<O extends ObservableInput<any>, R>(sources: O[], resultSelector: (...args: ObservedValueOf<O>[]) => R, scheduler?: SchedulerLike): Observable<R>;

resultSelector no longer supported, pipe to map instead
use the map operator instead of a result selector

rxjs/src/internal/observable/combineLatest.ts

Lines 33 to 44 in 95bd807

    
           /** @deprecated resultSelector no longer supported, pipe to map instead */ 
        
           export function combineLatest<O1 extends ObservableInput<any>, R>(v1: O1, resultSelector: (v1: ObservedValueOf<O1>) => R, scheduler?: SchedulerLike): Observable<R>; 
        
           /** @deprecated resultSelector no longer supported, pipe to map instead */ 
        
           export function combineLatest<O1 extends ObservableInput<any>, O2 extends ObservableInput<any>, R>(v1: O1, v2: O2, resultSelector: (v1: ObservedValueOf<O1>, v2: ObservedValueOf<O2>) => R, scheduler?: SchedulerLike): Observable<R>; 
        
           /** @deprecated resultSelector no longer supported, pipe to map instead */ 
        
           export function combineLatest<O1 extends ObservableInput<any>, O2 extends ObservableInput<any>, O3 extends ObservableInput<any>, R>(v1: O1, v2: O2, v3: O3, resultSelector: (v1: ObservedValueOf<O1>, v2: ObservedValueOf<O2>, v3: ObservedValueOf<O3>) => R, scheduler?: SchedulerLike): Observable<R>; 
        
           /** @deprecated resultSelector no longer supported, pipe to map instead */ 
        
           export function combineLatest<O1 extends ObservableInput<any>, O2 extends ObservableInput<any>, O3 extends ObservableInput<any>, O4 extends ObservableInput<any>, R>(v1: O1, v2: O2, v3: O3, v4: O4, resultSelector: (v1: ObservedValueOf<O1>, v2: ObservedValueOf<O2>, v3: ObservedValueOf<O3>, v4: ObservedValueOf<O4>) => R, scheduler?: SchedulerLike): Observable<R>; 
        
           /** @deprecated resultSelector no longer supported, pipe to map instead */ 
        
           export function combineLatest<O1 extends ObservableInput<any>, O2 extends ObservableInput<any>, O3 extends ObservableInput<any>, O4 extends ObservableInput<any>, O5 extends ObservableInput<any>, R>(v1: O1, v2: O2, v3: O3, v4: O4, v5: O5, resultSelector: (v1: ObservedValueOf<O1>, v2: ObservedValueOf<O2>, v3: ObservedValueOf<O3>, v4: ObservedValueOf<O4>, v5: ObservedValueOf<O5>) => R, scheduler?: SchedulerLike): Observable<R>; 
        
           /** @deprecated resultSelector no longer supported, pipe to map instead */ 
        
           export function combineLatest<O1 extends ObservableInput<any>, O2 extends ObservableInput<any>, O3 extends ObservableInput<any>, O4 extends ObservableInput<any>, O5 extends ObservableInput<any>, O6 extends ObservableInput<any>, R>(v1: O1, v2: O2, v3: O3, v4: O4, v5: O5, v6: O6, resultSelector: (v1: ObservedValueOf<O1>, v2: ObservedValueOf<O2>, v3: ObservedValueOf<O3>, v4: ObservedValueOf<O4>, v5: ObservedValueOf<O5>, v6: ObservedValueOf<O6>) => R, scheduler?: SchedulerLike): Observable<R>;

resultSelector no longer supported, pipe to map instead
use the map operator instead of a result selector

rxjs/src/internal/observable/combineLatest.ts

Lines 47 to 60 in 95bd807

    
           /** @deprecated Passing a scheduler here is deprecated, use {@link subscribeOn} and/or {@link observeOn} instead */ 
        
           export function combineLatest<O1 extends ObservableInput<any>>(sources: [O1], scheduler: SchedulerLike): Observable<[ObservedValueOf<O1>]>; 
        
           /** @deprecated Passing a scheduler here is deprecated, use {@link subscribeOn} and/or {@link observeOn} instead */ 
        
           export function combineLatest<O1 extends ObservableInput<any>, O2 extends ObservableInput<any>>(sources: [O1, O2], scheduler: SchedulerLike): Observable<[ObservedValueOf<O1>, ObservedValueOf<O2>]>; 
        
           /** @deprecated Passing a scheduler here is deprecated, use {@link subscribeOn} and/or {@link observeOn} instead */ 
        
           export function combineLatest<O1 extends ObservableInput<any>, O2 extends ObservableInput<any>, O3 extends ObservableInput<any>>(sources: [O1, O2, O3], scheduler: SchedulerLike): Observable<[ObservedValueOf<O1>, ObservedValueOf<O2>, ObservedValueOf<O3>]>; 
        
           /** @deprecated Passing a scheduler here is deprecated, use {@link subscribeOn} and/or {@link observeOn} instead */ 
        
           export function combineLatest<O1 extends ObservableInput<any>, O2 extends ObservableInput<any>, O3 extends ObservableInput<any>, O4 extends ObservableInput<any>>(sources: [O1, O2, O3, O4], scheduler: SchedulerLike): Observable<[ObservedValueOf<O1>, ObservedValueOf<O2>, ObservedValueOf<O3>, ObservedValueOf<O4>]>; 
        
           /** @deprecated Passing a scheduler here is deprecated, use {@link subscribeOn} and/or {@link observeOn} instead */ 
        
           export function combineLatest<O1 extends ObservableInput<any>, O2 extends ObservableInput<any>, O3 extends ObservableInput<any>, O4 extends ObservableInput<any>, O5 extends ObservableInput<any>>(sources: [O1, O2, O3, O4, O5], scheduler: SchedulerLike): Observable<[ObservedValueOf<O1>, ObservedValueOf<O2>, ObservedValueOf<O3>, ObservedValueOf<O4>, ObservedValueOf<O5>]>; 
        
           /** @deprecated Passing a scheduler here is deprecated, use {@link subscribeOn} and/or {@link observeOn} instead */ 
        
           export function combineLatest<O1 extends ObservableInput<any>, O2 extends ObservableInput<any>, O3 extends ObservableInput<any>, O4 extends ObservableInput<any>, O5 extends ObservableInput<any>, O6 extends ObservableInput<any>>(sources: [O1, O2, O3, O4, O5, O6], scheduler: SchedulerLike): Observable<[ObservedValueOf<O1>, ObservedValueOf<O2>, ObservedValueOf<O3>, ObservedValueOf<O4>, ObservedValueOf<O5>, ObservedValueOf<O6>]>; 
        
           /** @deprecated Passing a scheduler here is deprecated, use {@link subscribeOn} and/or {@link observeOn} instead */ 
        
           export function combineLatest<O extends ObservableInput<any>>(sources: O[], scheduler: SchedulerLike): Observable<ObservedValueOf<O>[]>;

Passing a scheduler here is deprecated, use {@link subscribeOn} and/or {@link observeOn} instead
use subscribeOn and/or observeOn instead of passing a scheduler

rxjs/src/internal/observable/combineLatest.ts

Lines 72 to 89 in 95bd807

    
           /** @deprecated Pass arguments in a single array instead `combineLatest([a, b, c])` */ 
        
           export function combineLatest<O1 extends ObservableInput<any>>(v1: O1, scheduler?: SchedulerLike): Observable<[ObservedValueOf<O1>]>; 
        
           /** @deprecated Pass arguments in a single array instead `combineLatest([a, b, c])` */ 
        
           export function combineLatest<O1 extends ObservableInput<any>, O2 extends ObservableInput<any>>(v1: O1, v2: O2, scheduler?: SchedulerLike): Observable<[ObservedValueOf<O1>, ObservedValueOf<O2>]>; 
        
           /** @deprecated Pass arguments in a single array instead `combineLatest([a, b, c])` */ 
        
           export function combineLatest<O1 extends ObservableInput<any>, O2 extends ObservableInput<any>, O3 extends ObservableInput<any>>(v1: O1, v2: O2, v3: O3, scheduler?: SchedulerLike): Observable<[ObservedValueOf<O1>, ObservedValueOf<O2>, ObservedValueOf<O3>]>; 
        
           /** @deprecated Pass arguments in a single array instead `combineLatest([a, b, c])` */ 
        
           export function combineLatest<O1 extends ObservableInput<any>, O2 extends ObservableInput<any>, O3 extends ObservableInput<any>, O4 extends ObservableInput<any>>(v1: O1, v2: O2, v3: O3, v4: O4, scheduler?: SchedulerLike): Observable<[ObservedValueOf<O1>, ObservedValueOf<O2>, ObservedValueOf<O3>, ObservedValueOf<O4>]>; 
        
           /** @deprecated Pass arguments in a single array instead `combineLatest([a, b, c])` */ 
        
           export function combineLatest<O1 extends ObservableInput<any>, O2 extends ObservableInput<any>, O3 extends ObservableInput<any>, O4 extends ObservableInput<any>, O5 extends ObservableInput<any>>(v1: O1, v2: O2, v3: O3, v4: O4, v5: O5, scheduler?: SchedulerLike): Observable<[ObservedValueOf<O1>, ObservedValueOf<O2>, ObservedValueOf<O3>, ObservedValueOf<O4>, ObservedValueOf<O5>]>; 
        
           /** @deprecated Pass arguments in a single array instead `combineLatest([a, b, c])` */ 
        
           export function combineLatest<O1 extends ObservableInput<any>, O2 extends ObservableInput<any>, O3 extends ObservableInput<any>, O4 extends ObservableInput<any>, O5 extends ObservableInput<any>, O6 extends ObservableInput<any>>(v1: O1, v2: O2, v3: O3, v4: O4, v5: O5, v6: O6, scheduler?: SchedulerLike): Observable<[ObservedValueOf<O1>, ObservedValueOf<O2>, ObservedValueOf<O3>, ObservedValueOf<O4>, ObservedValueOf<O5>, ObservedValueOf<O6>]>; 
        
           /** @deprecated Pass arguments in a single array instead `combineLatest([a, b, c])` */ 
        
           export function combineLatest<O extends ObservableInput<any>>(...observables: O[]): Observable<any[]>; 
        
           /** @deprecated Pass arguments in a single array instead `combineLatest([a, b, c])` */ 
        
           export function combineLatest<O extends ObservableInput<any>, R>(...observables: Array<ObservableInput<any> | ((...values: Array<any>) => R)>): Observable<R>;

Pass arguments in a single array instead `combineLatest([a, b, c])`
pass arguments in a single array instead `combineLatest([a, b, c])`

rxjs/src/internal/observable/combineLatest.ts

Lines 91 to 101 in 95bd807

    
           /** @deprecated resultSelector no longer supported, pipe to map instead */ 
        
           export function combineLatest<O extends ObservableInput<any>, R>(array: O[], resultSelector: (...values: ObservedValueOf<O>[]) => R, scheduler?: SchedulerLike): Observable<R>; 
        
           /** @deprecated Passing a scheduler here is deprecated, use {@link subscribeOn} and/or {@link observeOn} instead */ 
        
           export function combineLatest<O extends ObservableInput<any>>(...observables: Array<O | SchedulerLike>): Observable<any[]>; 
        
           /** @deprecated Passing a scheduler here is deprecated, use {@link subscribeOn} and/or {@link observeOn} instead */ 
        
           export function combineLatest<O extends ObservableInput<any>, R>(...observables: Array<O | ((...values: ObservedValueOf<O>[]) => R) | SchedulerLike>): Observable<R>; 
        
           /** @deprecated Passing a scheduler here is deprecated, use {@link subscribeOn} and/or {@link observeOn} instead */ 
        
           export function combineLatest<R>(...observables: Array<ObservableInput<any> | ((...values: Array<any>) => R) | SchedulerLike>): Observable<R>;

resultSelector no longer supported, pipe to map instead
use the map operator instead of a result selector

rxjs/src/internal/operators/partition.ts

Line 52 in 6259f20

* @deprecated use `partition` static creation function instead

use `partition` static creation function instead
use the static partition instead

rxjs/src/internal/observable/concat.ts

Lines 7 to 18 in 56cbd22

    
           /** @deprecated remove in v8. Passing a scheduler to concat is deprecated, please use {@link scheduled} and {@link concatAll} `scheduled([o1, o2], scheduler).pipe(concatAll())` */ 
        
           export function concat<O1 extends ObservableInput<any>>(v1: O1, scheduler: SchedulerLike): Observable<ObservedValueOf<O1>>; 
        
           /** @deprecated remove in v8. Passing a scheduler to concat is deprecated, please use {@link scheduled} and {@link concatAll} `scheduled([o1, o2], scheduler).pipe(concatAll())` */ 
        
           export function concat<O1 extends ObservableInput<any>, O2 extends ObservableInput<any>>(v1: O1, v2: O2, scheduler: SchedulerLike): Observable<ObservedValueOf<O1> | ObservedValueOf<O2>>; 
        
           /** @deprecated remove in v8. Passing a scheduler to concat is deprecated, please use {@link scheduled} and {@link concatAll} `scheduled([o1, o2], scheduler).pipe(concatAll())` */ 
        
           export function concat<O1 extends ObservableInput<any>, O2 extends ObservableInput<any>, O3 extends ObservableInput<any>>(v1: O1, v2: O2, v3: O3, scheduler: SchedulerLike): Observable<ObservedValueOf<O1> | ObservedValueOf<O2> | ObservedValueOf<O3>>; 
        
           /** @deprecated remove in v8. Passing a scheduler to concat is deprecated, please use {@link scheduled} and {@link concatAll} `scheduled([o1, o2], scheduler).pipe(concatAll())` */ 
        
           export function concat<O1 extends ObservableInput<any>, O2 extends ObservableInput<any>, O3 extends ObservableInput<any>, O4 extends ObservableInput<any>>(v1: O1, v2: O2, v3: O3, v4: O4, scheduler: SchedulerLike): Observable<ObservedValueOf<O1> | ObservedValueOf<O2> | ObservedValueOf<O3> | ObservedValueOf<O4>>; 
        
           /** @deprecated remove in v8. Passing a scheduler to concat is deprecated, please use {@link scheduled} and {@link concatAll} `scheduled([o1, o2], scheduler).pipe(concatAll())` */ 
        
           export function concat<O1 extends ObservableInput<any>, O2 extends ObservableInput<any>, O3 extends ObservableInput<any>, O4 extends ObservableInput<any>, O5 extends ObservableInput<any>>(v1: O1, v2: O2, v3: O3, v4: O4, v5: O5, scheduler: SchedulerLike): Observable<ObservedValueOf<O1> | ObservedValueOf<O2> | ObservedValueOf<O3> | ObservedValueOf<O4> | ObservedValueOf<O5>>; 
        
           /** @deprecated remove in v8. Passing a scheduler to concat is deprecated, please use {@link scheduled} and {@link concatAll} `scheduled([o1, o2], scheduler).pipe(concatAll())` */ 
        
           export function concat<O1 extends ObservableInput<any>, O2 extends ObservableInput<any>, O3 extends ObservableInput<any>, O4 extends ObservableInput<any>, O5 extends ObservableInput<any>, O6 extends ObservableInput<any>>(v1: O1, v2: O2, v3: O3, v4: O4, v5: O5, v6: O6, scheduler: SchedulerLike): Observable<ObservedValueOf<O1> | ObservedValueOf<O2> | ObservedValueOf<O3> | ObservedValueOf<O4> | ObservedValueOf<O5> | ObservedValueOf<O6>>;

remove in v8. Passing a scheduler to concat is deprecated, please use {@link scheduled} and {@link concatAll}
use scheduled and concatAll instead of passing a scheduler

rxjs/src/internal/observable/merge.ts

Lines 8 to 31 in b5a2ac9

    
           /** @deprecated use {@link scheduled} and {@link mergeAll} (e.g. `scheduled([ob1, ob2, ob3], scheduled).pipe(mergeAll())*/ 
        
           export function merge<T>(v1: ObservableInput<T>, scheduler: SchedulerLike): Observable<T>; 
        
           /** @deprecated use {@link scheduled} and {@link mergeAll} (e.g. `scheduled([ob1, ob2, ob3], scheduled).pipe(mergeAll())*/ 
        
           export function merge<T>(v1: ObservableInput<T>, concurrent: number, scheduler: SchedulerLike): Observable<T>; 
        
           /** @deprecated use {@link scheduled} and {@link mergeAll} (e.g. `scheduled([ob1, ob2, ob3], scheduled).pipe(mergeAll())*/ 
        
           export function merge<T, T2>(v1: ObservableInput<T>, v2: ObservableInput<T2>, scheduler: SchedulerLike): Observable<T | T2>; 
        
           /** @deprecated use {@link scheduled} and {@link mergeAll} (e.g. `scheduled([ob1, ob2, ob3], scheduled).pipe(mergeAll())*/ 
        
           export function merge<T, T2>(v1: ObservableInput<T>, v2: ObservableInput<T2>, concurrent: number, scheduler: SchedulerLike): Observable<T | T2>; 
        
           /** @deprecated use {@link scheduled} and {@link mergeAll} (e.g. `scheduled([ob1, ob2, ob3], scheduled).pipe(mergeAll())*/ 
        
           export function merge<T, T2, T3>(v1: ObservableInput<T>, v2: ObservableInput<T2>, v3: ObservableInput<T3>, scheduler: SchedulerLike): Observable<T | T2 | T3>; 
        
           /** @deprecated use {@link scheduled} and {@link mergeAll} (e.g. `scheduled([ob1, ob2, ob3], scheduled).pipe(mergeAll())*/ 
        
           export function merge<T, T2, T3>(v1: ObservableInput<T>, v2: ObservableInput<T2>, v3: ObservableInput<T3>, concurrent: number, scheduler: SchedulerLike): Observable<T | T2 | T3>; 
        
           /** @deprecated use {@link scheduled} and {@link mergeAll} (e.g. `scheduled([ob1, ob2, ob3], scheduled).pipe(mergeAll())*/ 
        
           export function merge<T, T2, T3, T4>(v1: ObservableInput<T>, v2: ObservableInput<T2>, v3: ObservableInput<T3>, v4: ObservableInput<T4>, scheduler: SchedulerLike): Observable<T | T2 | T3 | T4>; 
        
           /** @deprecated use {@link scheduled} and {@link mergeAll} (e.g. `scheduled([ob1, ob2, ob3], scheduled).pipe(mergeAll())*/ 
        
           export function merge<T, T2, T3, T4>(v1: ObservableInput<T>, v2: ObservableInput<T2>, v3: ObservableInput<T3>, v4: ObservableInput<T4>, concurrent: number, scheduler: SchedulerLike): Observable<T | T2 | T3 | T4>; 
        
           /** @deprecated use {@link scheduled} and {@link mergeAll} (e.g. `scheduled([ob1, ob2, ob3], scheduled).pipe(mergeAll())*/ 
        
           export function merge<T, T2, T3, T4, T5>(v1: ObservableInput<T>, v2: ObservableInput<T2>, v3: ObservableInput<T3>, v4: ObservableInput<T4>, v5: ObservableInput<T5>, scheduler: SchedulerLike): Observable<T | T2 | T3 | T4 | T5>; 
        
           /** @deprecated use {@link scheduled} and {@link mergeAll} (e.g. `scheduled([ob1, ob2, ob3], scheduled).pipe(mergeAll())*/ 
        
           export function merge<T, T2, T3, T4, T5>(v1: ObservableInput<T>, v2: ObservableInput<T2>, v3: ObservableInput<T3>, v4: ObservableInput<T4>, v5: ObservableInput<T5>, concurrent: number, scheduler: SchedulerLike): Observable<T | T2 | T3 | T4 | T5>; 
        
           /** @deprecated use {@link scheduled} and {@link mergeAll} (e.g. `scheduled([ob1, ob2, ob3], scheduled).pipe(mergeAll())*/ 
        
           export function merge<T, T2, T3, T4, T5, T6>(v1: ObservableInput<T>, v2: ObservableInput<T2>, v3: ObservableInput<T3>, v4: ObservableInput<T4>, v5: ObservableInput<T5>, v6: ObservableInput<T6>, scheduler: SchedulerLike): Observable<T | T2 | T3 | T4 | T5 | T6>; 
        
           /** @deprecated use {@link scheduled} and {@link mergeAll} (e.g. `scheduled([ob1, ob2, ob3], scheduled).pipe(mergeAll())*/ 
        
           export function merge<T, T2, T3, T4, T5, T6>(v1: ObservableInput<T>, v2: ObservableInput<T2>, v3: ObservableInput<T3>, v4: ObservableInput<T4>, v5: ObservableInput<T5>, v6: ObservableInput<T6>, concurrent: number, scheduler: SchedulerLike): Observable<T | T2 | T3 | T4 | T5 | T6>;

use {@link scheduled} and {@link mergeAll} (e.g. `scheduled([ob1, ob2, ob3], scheduled).pipe(mergeAll())
use scheduled and mergeAll instead of passing a scheduler

rxjs/src/internal/observable/of.ts

Lines 9 to 31 in 56cbd22

    
           /** @deprecated remove in v8. Use {@link scheduled} instead `scheduled([], scheduler)` */ 
        
           export function of(scheduler: SchedulerLike): Observable<never>; 
        
           /** @deprecated remove in v8. Use {@link scheduled} instead `scheduled([a, b, c], scheduler)` */ 
        
           export function of<T>(a: T, scheduler: SchedulerLike): Observable<T>; 
        
           /** @deprecated remove in v8. Use {@link scheduled} instead `scheduled([a, b, c], scheduler)` */ 
        
           export function of<T, T2>(a: T, b: T2, scheduler: SchedulerLike): Observable<T | T2>; 
        
           /** @deprecated remove in v8. Use {@link scheduled} instead `scheduled([a, b, c], scheduler)` */ 
        
           export function of<T, T2, T3>(a: T, b: T2, c: T3, scheduler: SchedulerLike): Observable<T | T2 | T3>; 
        
           /** @deprecated remove in v8. Use {@link scheduled} instead `scheduled([a, b, c], scheduler)` */ 
        
           export function of<T, T2, T3, T4>(a: T, b: T2, c: T3, d: T4, scheduler: SchedulerLike): Observable<T | T2 | T3 | T4>; 
        
           /** @deprecated remove in v8. Use {@link scheduled} instead `scheduled([a, b, c], scheduler)` */ 
        
           export function of<T, T2, T3, T4, T5>(a: T, b: T2, c: T3, d: T4, e: T5, scheduler: SchedulerLike): Observable<T | T2 | T3 | T4 | T5>; 
        
           /** @deprecated remove in v8. Use {@link scheduled} instead `scheduled([a, b, c], scheduler)` */ 
        
           export function of<T, T2, T3, T4, T5, T6>(a: T, b: T2, c: T3, d: T4, e: T5, f: T6, scheduler: SchedulerLike): Observable<T | T2 | T3 | T4 | T5 | T6>; 
        
           /** @deprecated remove in v8. Use {@link scheduled} instead `scheduled([a, b, c], scheduler)` */ 
        
           export function of<T, T2, T3, T4, T5, T6, T7>(a: T, b: T2, c: T3, d: T4, e: T5, f: T6, g: T7, scheduler: SchedulerLike): 
        
             Observable<T | T2 | T3 | T4 | T5 | T6 | T7>; 
        
           /** @deprecated remove in v8. Use {@link scheduled} instead `scheduled([a, b, c], scheduler)` */ 
        
           export function of<T, T2, T3, T4, T5, T6, T7, T8>(a: T, b: T2, c: T3, d: T4, e: T5, f: T6, g: T7, h: T8, scheduler: SchedulerLike): 
        
             Observable<T | T2 | T3 | T4 | T5 | T6 | T7 | T8>; 
        
           /** @deprecated remove in v8. Use {@link scheduled} instead `scheduled([a, b, c], scheduler)` */ 
        
           export function of<T, T2, T3, T4, T5, T6, T7, T8, T9>(a: T, b: T2, c: T3, d: T4, e: T5, f: T6, g: T7, h: T8, i: T9, scheduler: SchedulerLike): 
        
             Observable<T | T2 | T3 | T4 | T5 | T6 | T7 | T8 | T9>;

remove in v8. Use {@link scheduled} instead `scheduled([a, b, c], scheduler)`
Use scheduled instead

rxjs/src/internal/operators/startWith.ts

Lines 7 to 20 in b5a2ac9

    
           /** @deprecated use {@link scheduled} and {@link concatAll} (e.g. `scheduled([[a, b, c], source], scheduler).pipe(concatAll())`) */ 
        
           export function startWith<T>(scheduler: SchedulerLike): MonoTypeOperatorFunction<T>; 
        
           /** @deprecated use {@link scheduled} and {@link concatAll} (e.g. `scheduled([[a, b, c], source], scheduler).pipe(concatAll())`) */ 
        
           export function startWith<T, D>(v1: D, scheduler: SchedulerLike): OperatorFunction<T, T | D>; 
        
           /** @deprecated use {@link scheduled} and {@link concatAll} (e.g. `scheduled([[a, b, c], source], scheduler).pipe(concatAll())`) */ 
        
           export function startWith<T, D, E>(v1: D, v2: E, scheduler: SchedulerLike): OperatorFunction<T, T | D | E>; 
        
           /** @deprecated use {@link scheduled} and {@link concatAll} (e.g. `scheduled([[a, b, c], source], scheduler).pipe(concatAll())`) */ 
        
           export function startWith<T, D, E, F>(v1: D, v2: E, v3: F, scheduler: SchedulerLike): OperatorFunction<T, T | D | E | F>; 
        
           /** @deprecated use {@link scheduled} and {@link concatAll} (e.g. `scheduled([[a, b, c], source], scheduler).pipe(concatAll())`) */ 
        
           export function startWith<T, D, E, F, G>(v1: D, v2:  E, v3: F, v4: G, scheduler: SchedulerLike): OperatorFunction<T, T | D | E | F | G>; 
        
           /** @deprecated use {@link scheduled} and {@link concatAll} (e.g. `scheduled([[a, b, c], source], scheduler).pipe(concatAll())`) */ 
        
           export function startWith<T, D, E, F, G, H>(v1: D, v2: E, v3: F, v4: G, v5: H, scheduler: SchedulerLike): OperatorFunction<T, T | D | E | F | G | H>; 
        
           /** @deprecated use {@link scheduled} and {@link concatAll} (e.g. `scheduled([[a, b, c], source], scheduler).pipe(concatAll())`) */ 
        
           export function startWith<T, D, E, F, G, H, I>(v1: D, v2: E, v3: F, v4: G, v5: H, v6: I, scheduler: SchedulerLike): OperatorFunction<T, T | D | E | F | G | H | I>;

use {@link scheduled} and {@link concatAll} (e.g. `scheduled([[a, b, c], source], scheduler).pipe(concatAll())`)
use scheduled and concatAll instead of passing a scheduler

rxjs/src/internal/operators/endWith.ts

Lines 7 to 29 in 986be2f

    
           /** @deprecated use {@link scheduled} and {@link concatAll} (e.g. `scheduled([source, [a, b, c]], scheduler).pipe(concatAll())`) */ 
        
           export function endWith<T>(scheduler: SchedulerLike): MonoTypeOperatorFunction<T>; 
        
           /** @deprecated use {@link scheduled} and {@link concatAll} (e.g. `scheduled([source, [a, b, c]], scheduler).pipe(concatAll())`) */ 
        
           export function endWith<T, A>(v1: A, scheduler: SchedulerLike): OperatorFunction<T, T | A>; 
        
           /** @deprecated use {@link scheduled} and {@link concatAll} (e.g. `scheduled([source, [a, b, c]], scheduler).pipe(concatAll())`) */ 
        
           export function endWith<T, A, B>(v1: A, v2: B, scheduler: SchedulerLike): OperatorFunction<T, T | A | B>; 
        
           /** @deprecated use {@link scheduled} and {@link concatAll} (e.g. `scheduled([source, [a, b, c]], scheduler).pipe(concatAll())`) */ 
        
           export function endWith<T, A, B, C>(v1: A, v2: B, v3: C, scheduler: SchedulerLike): OperatorFunction<T, T | A | B | C>; 
        
           /** @deprecated use {@link scheduled} and {@link concatAll} (e.g. `scheduled([source, [a, b, c]], scheduler).pipe(concatAll())`) */ 
        
           export function endWith<T, A, B, C, D>(v1: A, v2: B, v3: C, v4: D, scheduler: SchedulerLike): OperatorFunction<T, T | A | B | C | D>; 
        
           /** @deprecated use {@link scheduled} and {@link concatAll} (e.g. `scheduled([source, [a, b, c]], scheduler).pipe(concatAll())`) */ 
        
           export function endWith<T, A, B, C, D, E>(v1: A, v2: B, v3: C, v4: D, v5: E, scheduler: SchedulerLike): OperatorFunction<T, T | A | B | C | D | E>; 
        
           /** @deprecated use {@link scheduled} and {@link concatAll} (e.g. `scheduled([source, [a, b, c]], scheduler).pipe(concatAll())`) */ 
        
           export function endWith<T, A, B, C, D, E, F>(v1: A, v2: B, v3: C, v4: D, v5: E, v6: F, scheduler: SchedulerLike): OperatorFunction<T, T | A | B | C | D | E | F>; 
        
           export function endWith<T, A>(v1: A): OperatorFunction<T, T | A>; 
        
           export function endWith<T, A, B>(v1: A, v2: B): OperatorFunction<T, T | A | B>; 
        
           export function endWith<T, A, B, C>(v1: A, v2: B, v3: C): OperatorFunction<T, T | A | B | C>; 
        
           export function endWith<T, A, B, C, D>(v1: A, v2: B, v3: C, v4: D): OperatorFunction<T, T | A | B | C | D>; 
        
           export function endWith<T, A, B, C, D, E>(v1: A, v2: B, v3: C, v4: D, v5: E): OperatorFunction<T, T | A | B | C | D | E>; 
        
           export function endWith<T, A, B, C, D, E, F>(v1: A, v2: B, v3: C, v4: D, v5: E, v6: F): OperatorFunction<T, T | A | B | C | D | E | F>; 
        
           export function endWith<T, Z = T>(...array: Z[]): OperatorFunction<T, T | Z>; 
        
           /** @deprecated use {@link scheduled} and {@link concatAll} (e.g. `scheduled([source, [a, b, c]], scheduler).pipe(concatAll())`) */

use {@link scheduled} and {@link concatAll} (e.g. `scheduled([source, [a, b, c]], scheduler).pipe(concatAll())`)
use scheduled and concatAll instead of passing a scheduler

rxjs/src/internal/observable/from.ts

Line 7 in b5a2ac9

/** @deprecated use {@link scheduled} instead. */

use {@link scheduled} instead.
use scheduled instead

rxjs/src/internal/observable/of.ts

Line 35 in 56cbd22

    
           /** @deprecated remove in v8. Do not use generic arguments directly, allow inference or cast with `as` */

remove in v8. Do not use generic arguments directly, allow inference or cast with `as`
do not use generic arguments directly, allow inference or assert with `as`

rxjs/src/internal/observable/forkJoin.ts

Lines 12 to 23 in 7926122

    
           /** @deprecated Use the version that takes an array of Observables instead */ 
        
           export function forkJoin<T>(v1: SubscribableOrPromise<T>): Observable<[T]>; 
        
           /** @deprecated Use the version that takes an array of Observables instead */ 
        
           export function forkJoin<T, T2>(v1: ObservableInput<T>, v2: ObservableInput<T2>): Observable<[T, T2]>; 
        
           /** @deprecated Use the version that takes an array of Observables instead */ 
        
           export function forkJoin<T, T2, T3>(v1: ObservableInput<T>, v2: ObservableInput<T2>, v3: ObservableInput<T3>): Observable<[T, T2, T3]>; 
        
           /** @deprecated Use the version that takes an array of Observables instead */ 
        
           export function forkJoin<T, T2, T3, T4>(v1: ObservableInput<T>, v2: ObservableInput<T2>, v3: ObservableInput<T3>, v4: ObservableInput<T4>): Observable<[T, T2, T3, T4]>; 
        
           /** @deprecated Use the version that takes an array of Observables instead */ 
        
           export function forkJoin<T, T2, T3, T4, T5>(v1: ObservableInput<T>, v2: ObservableInput<T2>, v3: ObservableInput<T3>, v4: ObservableInput<T4>, v5: ObservableInput<T5>): Observable<[T, T2, T3, T4, T5]>; 
        
           /** @deprecated Use the version that takes an array of Observables instead */ 
        
           export function forkJoin<T, T2, T3, T4, T5, T6>(v1: ObservableInput<T>, v2: ObservableInput<T2>, v3: ObservableInput<T3>, v4: ObservableInput<T4>, v5: ObservableInput<T5>, v6: ObservableInput<T6>): Observable<[T, T2, T3, T4, T5, T6]>;

Use the version that takes an array of Observables instead
pass arguments in a single array instead `forkJoin([a, b, c])`

rxjs/src/internal/observable/concat.ts

Lines 7 to 17 in 56cbd22

    
           /** @deprecated remove in v8. Passing a scheduler to concat is deprecated, please use {@link scheduled} and {@link concatAll} `scheduled([o1, o2], scheduler).pipe(concatAll())` */ 
        
           export function concat<O1 extends ObservableInput<any>>(v1: O1, scheduler: SchedulerLike): Observable<ObservedValueOf<O1>>; 
        
           /** @deprecated remove in v8. Passing a scheduler to concat is deprecated, please use {@link scheduled} and {@link concatAll} `scheduled([o1, o2], scheduler).pipe(concatAll())` */ 
        
           export function concat<O1 extends ObservableInput<any>, O2 extends ObservableInput<any>>(v1: O1, v2: O2, scheduler: SchedulerLike): Observable<ObservedValueOf<O1> | ObservedValueOf<O2>>; 
        
           /** @deprecated remove in v8. Passing a scheduler to concat is deprecated, please use {@link scheduled} and {@link concatAll} `scheduled([o1, o2], scheduler).pipe(concatAll())` */ 
        
           export function concat<O1 extends ObservableInput<any>, O2 extends ObservableInput<any>, O3 extends ObservableInput<any>>(v1: O1, v2: O2, v3: O3, scheduler: SchedulerLike): Observable<ObservedValueOf<O1> | ObservedValueOf<O2> | ObservedValueOf<O3>>; 
        
           /** @deprecated remove in v8. Passing a scheduler to concat is deprecated, please use {@link scheduled} and {@link concatAll} `scheduled([o1, o2], scheduler).pipe(concatAll())` */ 
        
           export function concat<O1 extends ObservableInput<any>, O2 extends ObservableInput<any>, O3 extends ObservableInput<any>, O4 extends ObservableInput<any>>(v1: O1, v2: O2, v3: O3, v4: O4, scheduler: SchedulerLike): Observable<ObservedValueOf<O1> | ObservedValueOf<O2> | ObservedValueOf<O3> | ObservedValueOf<O4>>; 
        
           /** @deprecated remove in v8. Passing a scheduler to concat is deprecated, please use {@link scheduled} and {@link concatAll} `scheduled([o1, o2], scheduler).pipe(concatAll())` */ 
        
           export function concat<O1 extends ObservableInput<any>, O2 extends ObservableInput<any>, O3 extends ObservableInput<any>, O4 extends ObservableInput<any>, O5 extends ObservableInput<any>>(v1: O1, v2: O2, v3: O3, v4: O4, v5: O5, scheduler: SchedulerLike): Observable<ObservedValueOf<O1> | ObservedValueOf<O2> | ObservedValueOf<O3> | ObservedValueOf<O4> | ObservedValueOf<O5>>; 
        
           /** @deprecated remove in v8. Passing a scheduler to concat is deprecated, please use {@link scheduled} and {@link concatAll} `scheduled([o1, o2], scheduler).pipe(concatAll())` */

remove in v8. Passing a scheduler to concat is deprecated, please use {@link scheduled} and {@link concatAll} `scheduled([o1, o2], scheduler).pipe(concatAll())`
use scheduled and concatAll instead of passing a scheduler

rxjs/src/internal/Notification.ts

Line 9 in fc9186c

    
            * @deprecated NotificationKind is deprecated as const enums are not compatible with isolated modules. Use a string literal instead.

NotificationKind is deprecated as const enums are not compatible with isolated modules. Use a string literal instead.
use a string literal instead of a const enum

rxjs/src/internal/testing/TestScheduler.ts

Line 40 in b713d39

* @deprecated remove in v8. Not for public use.

remove in v8. Not for public use.
internal use only

rxjs/src/internal/testing/TestScheduler.ts

Line 45 in b713d39

* @deprecated remove in v8. Not for public use.

remove in v8. Not for public use.
internal use only

rxjs/src/internal/scheduler/VirtualTimeScheduler.ts

Line 8 in 8c32ed0

    
           /** @deprecated remove in v8. `frameTimeFactor` is not used in VirtualTimeScheduler directly. */

remove in v8. `frameTimeFactor` is not used in VirtualTimeScheduler directly.
no longer used directly

rxjs/src/internal/scheduler/VirtualTimeScheduler.ts

Line 21 in 8c32ed0

* @deprecated remove in v8. Should be a private API.

remove in v8. Should be a private API.
internal use only

rxjs/src/internal/observable/generate.ts

Line 68 in ba8a95f

    
            * @param {function (state: S): T} resultSelector Selector function for results produced in the sequence. (deprecated)

(This would need an overload signature without the resultSelector. AFAICT, ATM, it cannot be deprecated.)
use the map operator instead of a result selector

BioPhoton · 2019-12-26T11:34:38Z

@cartant

I changed the sentence:
"use the map operator, on the inner observable, instead of a result selector"
to
"use ${otherOperator} with an inner map instead of a result selector"
for all 'xMapTo' operators.

I did it because the refactoring is different for xMapTo operators and we need to use other operators.

BioPhoton · 2020-01-03T20:02:44Z

@cartant I would need some help with the listed messages.
As before the new suggested message in the code is the information in question:

Deprecation name
- SourceLink
- Link to current message in code
- Suggested new message in code based on your previous message style or 'TODO' if I need more than just an ok
- Reason
- NOTES: Some notes

Please provide information for entries marked with TODO, answer entries marked with NOTES:
and change my suggested messages if needed.

Thanks for your time front off!

5.3.0_deprecation-symbol-rxSubscriber
- https://github.com/ReactiveX/rxjs/blob/5.3.0/src/symbol/rxSubscriber.ts#L9
- use rxSubscriber instead
- TODO
- NOTES
  - How to suggest a refactoring?
5.3.0_deprecation-symbol-iterator
- https://github.com/ReactiveX/rxjs/blob/5.3.0/src/symbol/iterator.ts#L36
- use iterator instead
- TODO
6.0.0-tenacious-rc.2_deprecation-class-SubscribeOnObservable
- https://github.com/ReactiveX/rxjs/blob/6.0.0-tenacious-rc.2/src/internal/observable/SubscribeOnObservable.ts#L42
- This is an internal implementation detail, do not use.
- internal use only
- NOTES
  - How to suggest a refactoring?
  - Will the assess modifier change to private? If not what will change?
  - Above questions are the same for all other similar items.
6.0.0-turbo-rc.4_deprecation-class-GroupedObservable
- https://github.com/ReactiveX/rxjs/blob/6.0.0-turbo-rc.4/src/internal/operators/groupBy.ts#L256
- Do not construct this type. Internal use only
- internal use only
- NOTES
  - Is there an new interface?
6.0.0-tenacious-rc.2_deprecation-class-AjaxObservable
- https://github.com/ReactiveX/rxjs/blob/6.0.0-tenacious-rc.2/src/internal/observable/dom/AjaxObservable.ts#L182
- This is an internal implementation detail, do not use.
- internal use only
6.0.0-tenacious-rc.2_deprecation-class-Subscriber
- https://github.com/ReactiveX/rxjs/blob/6.0.0-tenacious-rc.2/src/internal/Subscriber.ts#L155
- This is an internal implementation detail, do not use.
- internal use only
6.0.0-tenacious-rc.2_deprecation-class-TimeoutWithSubscriber
- https://github.com/ReactiveX/rxjs/blob/6.0.0-tenacious-rc.2/src/internal/operators/timeoutWith.ts#L132
- This is an internal implementation detail, do not use.
- internal use only
6.0.0-tenacious-rc.2_deprecation-class-ConnectableObservable
- https://github.com/ReactiveX/rxjs/blob/6.0.0-tenacious-rc.2/src/internal/observable/ConnectableObservable.ts#L25
- This is an internal implementation detail, do not use.
- internal use only
6.0.0-tenacious-rc.2_deprecation-class-RepeatWhenSubscriber
- https://github.com/ReactiveX/rxjs/blob/6.0.0-tenacious-rc.2/src/internal/operators/repeatWhen.ts#L89
- This is an internal implementation detail, do not use.
- internal use only
6.0.0-tenacious-rc.2_deprecation-class-RepeatWhenSubscriber
- https://github.com/ReactiveX/rxjs/blob/6.0.0-tenacious-rc.2/src/internal/operators/repeatWhen.ts#L103
- This is an internal implementation detail, do not use.
- internal use only
6.0.0-tenacious-rc.2_deprecation-class-WindowToggleSubscriber
- https://github.com/ReactiveX/rxjs/blob/6.0.0-tenacious-rc.2/src/internal/operators/windowToggle.ts#L137
- This is an internal implementation detail, do not use.
- internal use only
6.0.0-tenacious-rc.2_deprecation-class-WindowSubscriber
- https://github.com/ReactiveX/rxjs/blob/6.0.0-tenacious-rc.2/src/internal/operators/window.ts#L109
- This is an internal implementation detail, do not use.
- internal use only
6.0.0-tenacious-rc.2_deprecation-class-GroupBySubscriber
- https://github.com/ReactiveX/rxjs/blob/6.0.0-tenacious-rc.2/src/internal/operators/groupBy.ts#L237
- This is an internal implementation detail, do not use.
- internal use only
6.0.0-tenacious-rc.2_deprecation-class-GroupedObservable
- https://github.com/ReactiveX/rxjs/blob/6.0.0-tenacious-rc.2/src/internal/operators/groupBy.ts#L262
- This is an internal implementation detail, do not use.
- internal use only
6.0.0-tenacious-rc.2_deprecation-class-BufferWhenSubscriber
- https://github.com/ReactiveX/rxjs/blob/6.0.0-tenacious-rc.2/src/internal/operators/bufferWhen.ts#L88
- This is an internal implementation detail, do not use.
- internal use only
6.0.0-tenacious-rc.2_deprecation-class-BufferTimeSubscriber
- https://github.com/ReactiveX/rxjs/blob/6.0.0-tenacious-rc.2/src/internal/operators/bufferTime.ts#L173
- This is an internal implementation detail, do not use.
- internal use only
6.0.0-tenacious-rc.2_deprecation-class-AsyncAction
- https://github.com/ReactiveX/rxjs/blob/6.0.0-tenacious-rc.2/src/internal/scheduler/AsyncAction.ts#L132
- This is an internal implementation detail, do not use.
- internal use only
6.0.0-tenacious-rc.2_deprecation-class-Subscriber
- https://github.com/ReactiveX/rxjs/blob/6.0.0-tenacious-rc.2/src/internal/Subscriber.ts#L155
- This is an internal implementation detail, do not use.
- internal use only
6.0.0-tenacious-rc.2_deprecation-class-Subject
- https://github.com/ReactiveX/rxjs/blob/6.0.0-tenacious-rc.2/src/internal/Subject.ts#L103
- This is an internal implementation detail, do not use.
- internal use only
6.0.0-tenacious-rc.2_deprecation-class-Subject
- https://github.com/ReactiveX/rxjs/blob/6.0.0-tenacious-rc.2/src/internal/Subject.ts#L112
- This is an internal implementation detail, do not use.
- internal use only
6.0.0-tenacious-rc.2_deprecation-class-BehaviorSubject
- https://github.com/ReactiveX/rxjs/blob/6.0.0-tenacious-rc.2/src/internal/BehaviorSubject.ts#L20
- This is an internal implementation detail, do not use.
- internal use only
6.0.0-tenacious-rc.2_deprecation-class-AsyncScheduler
- https://github.com/ReactiveX/rxjs/blob/6.1.0/src/internal/scheduler/AsyncScheduler.ts#L14
- internal use only
- internal use only
6.0.0-tenacious-rc.2_deprecation-class-AsyncScheduler
- https://github.com/ReactiveX/rxjs/blob/6.1.0/src/internal/scheduler/AsyncScheduler.ts#L22
- internal use only
- internal use only
6.2.1_deprecation-function-delayWhen
- https://github.com/ReactiveX/rxjs/blob/6.2.1/src/internal/operators/delayWhen.ts#L11
- In future versions, empty notifiers will no longer re-emit the source value on the output observable.
- TODO
6.3.3_deprecation-const-rxSubscriber
- https://github.com/ReactiveX/rxjs/blob/6.3.3/src/internal/symbol/rxSubscriber.ts#L1
- do not use, this is no longer checked by RxJS internals
- TODO
6.4.0_deprecation-class-Subject
- https://github.com/ReactiveX/rxjs/blob/6.4.0/src/internal/Subject.ts#L49
- use new Subject() instead
- TODO
6.4.0_deprecation-interface-Subscribable
- https://github.com/ReactiveX/rxjs/blob/6.4.0/src/internal/types.ts#L43
- Use an observer instead of a complete callback
- use an observer instead of separate callbacks
6.4.0_deprecation-interface-Subscribable
- https://github.com/ReactiveX/rxjs/blob/6.4.0/src/internal/types.ts#L45
- Use an observer instead of a complete callback
- use an observer instead of separate callbacks
6.4.0_deprecation-interface-Subscribable
- https://github.com/ReactiveX/rxjs/blob/6.4.0/src/internal/types.ts#L48
- Use an observer instead of a complete callback
- use an observer instead of separate callbacks

niklas-wortmann

I didn't checkout the pr so far because I really struggle with understanding the code at all. It's so bloated by comments. But additionally I think we need to reconsider the approach to tackle this problem. I barely believe one will be able to maintain the code at all. Let's have a chat offline about how to go on with this.

docs_app/content/navigation.json

docs_app/content/guide/v6/migration.md

docs_app/content/marketing/deprecations.ts

docs_app/src/app/custom-elements/code/code.component.ts

docs_app/src/app/custom-elements/migration-timeline/data-access/migration-item.ts

...c/app/custom-elements/migration-timeline/data-access/migration-timeline-struckture/README.md

...stom-elements/migration-timeline/data-access/migration-timeline-struckture/migration-item.ts

...c/app/custom-elements/migration-timeline/data-access/migration-timeline-struckture/README.md

...stom-elements/migration-timeline/data-access/migration-timeline-struckture/migration-item.ts

BioPhoton · 2020-01-26T22:41:31Z

Hi @jwo719 !

Thanks you found time to take a look!

As this PR is hanging around quite a while without any feedback at all I'm sure a lot of things need to be adopted!

I'll update your first feedback and would be happy to get more after the first fixes.

BioPhoton · 2020-01-27T04:16:20Z

@jwo719 Resolved all requests.

The comment about weird formatting could be discussed to adjust my ide to the standard.

I'm happy to get more detailed feedback on the current status

BioPhoton · 2020-01-27T15:12:42Z

BioPhoton · 2020-01-29T21:41:24Z

This issue is related to:

niklas-wortmann

The code itself looks pretty fine I just requested some subtle changes, but it's not compiling right now so I couldn't test it manually and also I need to test it from an accessibility point of view. Additionally, I didn't saw any test, I'd really appreciate some unit tests

docs_app/src/app/custom-elements/migration-timeline/Workflow.md

...imeline/components/migration-timeline/missing-information/deprecation-item-form.component.ts

docs_app/src/app/shared/state.service.ts

docs_app/src/styles/2-modules/_migration-timeline-pages.scss

…ssages. first draft of json.

… navigation link in registry

…plete versions i.e. 8.x.x)

…der for empty lists

…o reduce logic

…m deprecation

niklas-wortmann · 2020-10-09T00:56:15Z

@BioPhoton we talked about this already, this is an amazing pr, it would just be very difficult for us to maintain this properly.

cartant reviewed Nov 17, 2019

View reviewed changes

niklas-wortmann requested changes Jan 26, 2020

View reviewed changes

martinsik mentioned this pull request Feb 5, 2020

Include changelog history for each operator on their doc page #4593

Open

5 tasks

niklas-wortmann requested changes Mar 13, 2020

View reviewed changes

BioPhoton force-pushed the 4776_Add-doc-URLs-to-deprecation-messages branch from 13fc8d9 to 6b92268 Compare April 6, 2020 05:58

BioPhoton added 18 commits May 2, 2020 14:59

docs(deprecation-timeline): implemented structure and patterns for me…

5c047f9

…ssages. first draft of json.

docs(deprecation-timeline): start resolving todo's

f068a46

docs(deprecation-timeline): start resolving todo's

15e89d2

docs(deprecation-timeline): Setup menu items, container component and…

2c91936

… navigation link in registry

docs(deprecation-timeline): Implemented release selection logic

1587192

docs(deprecation-timeline): Implemented basic routing interaction

cf85c1b

docs(deprecation-timeline): Implemented messages for empty lists

ec38ba7

docs(docs-app): Fix typo

d58f998

docs(migration-timeline): Style release section

f559d28

docs(migration-timeline): Linking

2b1c04a

docs(migration-timeline): Implemented graceful version linking (incom…

b1f763e

…plete versions i.e. 8.x.x)

docs(migration-timeline): Implemented graceful version linking (incom…

a481a4e

…plete versions i.e. 8.x.x)

docs(migration-timeline): Fixed date styling and implemented placehol…

b9b24c5

…der for empty lists

docs(migration-timeline): Fixed typings for state select function

de1aad1

docs(migration-timeline): Fixed typings for state set function

e9e9c71

docs(migration-timeline): Added Todos in comments

ff26a2c

docs(migration-timeline): Typing

8c34c40

docs(migration-timeline): comments

c762fd6

BioPhoton added 20 commits May 2, 2020 14:59

docs(migration-timeline): removed unused component

26b0166

docs(migration-timeline): fixed imports

5903629

docs(migration-timeline): remove reactivity example change

133cd12

docs(migration-timeline): introduced smaller functions

5e3ffb5

docs(migration-timeline): removed empty lines

f091c52

docs(migration-timeline): removed spaces, introduced sub observable t…

e03657d

…o reduce logic

docs(migration-timeline): enables OnPush

cc2ab31

docs(migration-timeline): created multiple smaller components

e489ee6

docs(migration-timeline): normalized state

4620a48

docs(migration-timeline): fixed property binding

433c6fd

docs(migration-timeline): updated typing

22cd3a5

docs(migration-timeline): updated typing

4944711

docs(migration-timeline): updated typing

12f1d55

docs(migration-timeline): auto generate breakingChange completely fro…

92b8386

…m deprecation

docs(migration-timeline): adopted functions, implemented trimFns

8b61620

docs(migration-timeline): implemented preview and smart defaults

da2a4f5

docs(migration-timeline): change defaults

a4556f2

docs(migration-timeline): remove unused inputs

493ca20

feat(migration-timeline): renamed components, cleanup

efa7a8a

feat(migration-timeline): cleanup

0dc8c2d

BioPhoton force-pushed the 4776_Add-doc-URLs-to-deprecation-messages branch from 781af61 to 0dc8c2d Compare May 2, 2020 13:00

BioPhoton added 4 commits May 2, 2020 15:54

Rebase master and fix broken build

938bcf4

Improved typing

69f667a

fix linking and sorting

83cab68

fix imports

de3e01f

niklas-wortmann added AGENDA ITEM Flagged for discussion at core team meetings and removed AGENDA ITEM Flagged for discussion at core team meetings labels May 5, 2020

BioPhoton mentioned this pull request Jul 27, 2020

Process Overview push-based/deprecation-manager#13

Closed

niklas-wortmann closed this Oct 9, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

4776 add doc ur ls to deprecation messages #5128

4776 add doc ur ls to deprecation messages #5128

BioPhoton commented Nov 7, 2019 •

edited

Loading

cartant Nov 17, 2019 •

edited

Loading

cartant commented Nov 18, 2019 •

edited

Loading

BioPhoton commented Dec 26, 2019

BioPhoton commented Jan 3, 2020 •

edited

Loading

niklas-wortmann left a comment

BioPhoton commented Jan 26, 2020

BioPhoton commented Jan 27, 2020

BioPhoton commented Jan 27, 2020 •

edited

Loading

BioPhoton commented Jan 29, 2020 •

edited

Loading

niklas-wortmann left a comment

niklas-wortmann commented Oct 9, 2020

4776 add doc ur ls to deprecation messages #5128

4776 add doc ur ls to deprecation messages #5128

Conversation

BioPhoton commented Nov 7, 2019 • edited Loading

WORK IN PROGRESS

Migration-Timeline

Core Features

Optional Features (after core features are done)

Current Progress

Data

Manual work:

Edge Cases to clarify

First Draft

cartant Nov 17, 2019 • edited Loading

Choose a reason for hiding this comment

Reason

Implication

Before Deprecation

After Deprecation

cartant commented Nov 18, 2019 • edited Loading

BioPhoton commented Dec 26, 2019

BioPhoton commented Jan 3, 2020 • edited Loading

niklas-wortmann left a comment

Choose a reason for hiding this comment

BioPhoton commented Jan 26, 2020

BioPhoton commented Jan 27, 2020

BioPhoton commented Jan 27, 2020 • edited Loading

BioPhoton commented Jan 29, 2020 • edited Loading

niklas-wortmann left a comment

Choose a reason for hiding this comment

niklas-wortmann commented Oct 9, 2020

BioPhoton commented Nov 7, 2019 •

edited

Loading

cartant Nov 17, 2019 •

edited

Loading

cartant commented Nov 18, 2019 •

edited

Loading

BioPhoton commented Jan 3, 2020 •

edited

Loading

BioPhoton commented Jan 27, 2020 •

edited

Loading

BioPhoton commented Jan 29, 2020 •

edited

Loading