-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ESDoc related stuff #5462
Remove ESDoc related stuff #5462
Conversation
This is an amazing pull request. Thanks a lot for taking care of this. I need to check it out locally. I'll try to take care of this, this weekend and come back to you! |
Thank you @niklas-wortmann. I hope you won't have problems when you try this. |
e8d2226
to
b4c446f
Compare
Hey @niklas-wortmann, since this PR changes lots of files, a since lots of conflicts occur over time, please let me know once you start your review, so I can rebase and resolve conflicts at that time. Or, if you want to do it on your own, please do. |
b4c446f
to
8d344f5
Compare
🤷♂️ I wouldn't worry about it IMO, if folks start complaining then we can see what we can do. My gut tells me this is already pretty safe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for splitting the changes into separate commits, @jakovljevic-mladen This was very easy to review. ❤
Thank you, @jakovljevic-mladen! |
Hi everyone. Here's a cleanup PR. I'm not completely sure that this should be done, so I've split code changes to three commits, where I hope that at least one or two of them might be merged, if not all.
@owner
is removed (51a860b) from most of the docs, I have removed almost all other@owner
leftovers. There's only one place where@owner
appears:Observable
'screate
method.Please let me know if these changes make sense. If some of them don't, I can remove them.