From e62b0acb3e0825ddb31fc49d02cb25146311fa0c Mon Sep 17 00:00:00 2001 From: Nicholas Jamieson Date: Sat, 1 May 2021 11:42:08 +1000 Subject: [PATCH 1/2] docs: mention tighter fromEvent types --- docs_app/content/6-to-7-change-summary.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/docs_app/content/6-to-7-change-summary.md b/docs_app/content/6-to-7-change-summary.md index d255176035..17dad538f2 100644 --- a/docs_app/content/6-to-7-change-summary.md +++ b/docs_app/content/6-to-7-change-summary.md @@ -42,6 +42,10 @@ This document contains a detailed list of changes between RxJS 6.x and RxJS 7.x, - Generic signatures have changed. Do not explicitly pass generics. +### fromEvent + +- The `fromEvent` signatures have been changed and there are now separate signatures for each type of target - DOM, Node, jQuery, etc. That means that attempts to pass options - like `{ once: true }` - to targets that do not support options will result in a TypeScript error. + ### GroupedObservable - No longer publicly exposes `_subscribe` From 0a3f0208cea21e08183f0f45032ee9dcb9dad70f Mon Sep 17 00:00:00 2001 From: Nicholas Jamieson Date: Sat, 1 May 2021 13:57:15 +1000 Subject: [PATCH 2/2] docs: improve grammar --- docs_app/content/6-to-7-change-summary.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs_app/content/6-to-7-change-summary.md b/docs_app/content/6-to-7-change-summary.md index 17dad538f2..490ae21e7f 100644 --- a/docs_app/content/6-to-7-change-summary.md +++ b/docs_app/content/6-to-7-change-summary.md @@ -44,7 +44,7 @@ This document contains a detailed list of changes between RxJS 6.x and RxJS 7.x, ### fromEvent -- The `fromEvent` signatures have been changed and there are now separate signatures for each type of target - DOM, Node, jQuery, etc. That means that attempts to pass options - like `{ once: true }` - to targets that do not support options will result in a TypeScript error. +- The `fromEvent` signatures have been changed and there are now separate signatures for each type of target - DOM, Node, jQuery, etc. That means that an attempt to pass options - like `{ once: true }` - to a target that does not support an options argument will result in a TypeScript error. ### GroupedObservable