Skip to content

Commit

Permalink
Use WITHOUT ROWID table clustering for primary keys (#44)
Browse files Browse the repository at this point in the history
* Use `WITHOUT ROWID` table clustering for tables

* lint
  • Loading branch information
ohaibbq authored Apr 11, 2024
1 parent 9b5a4e0 commit 457aa4c
Show file tree
Hide file tree
Showing 2 changed files with 45 additions and 2 deletions.
31 changes: 31 additions & 0 deletions driver_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package zetasqlite_test
import (
"context"
"database/sql"
"strings"
"testing"

zetasqlite "github.com/goccy/go-zetasqlite"
Expand Down Expand Up @@ -179,6 +180,36 @@ CREATE TABLE IF NOT EXISTS Singers (
})
}

func TestCreateTable(t *testing.T) {
t.Run("primary keys", func(t *testing.T) {
db, err := sql.Open("zetasqlite", ":memory:")
if err != nil {
t.Fatal(err)
}
if _, err := db.Exec(`
CREATE TABLE IF NOT EXISTS Singers (
SingerId INT64 NOT NULL PRIMARY KEY,
FirstName STRING(1024),
LastName STRING(1024)
)`); err != nil {
t.Fatal(err)
}
stmt, err := db.Prepare("INSERT Singers (SingerId, FirstName, LastName) VALUES (@SingerID, @FirstName, @LastName)")
if err != nil {
t.Fatal(err)
}
_, err = stmt.Exec(int64(1), "Kylie", "Minogue")
if err != nil {
t.Fatal(err)
}

_, err = stmt.Exec(int64(1), "Miss", "Kitten")
if !strings.HasSuffix(err.Error(), "UNIQUE constraint failed: Singers.SingerId") {
t.Fatalf("expected failed unique constraint err, got: %s", err)
}
})
}

func TestPreparedStatements(t *testing.T) {
t.Run("prepared select", func(t *testing.T) {
db, err := sql.Open("zetasqlite", ":memory:")
Expand Down
16 changes: 14 additions & 2 deletions internal/spec.go
Original file line number Diff line number Diff line change
Expand Up @@ -139,11 +139,23 @@ func (s *TableSpec) SQLiteSchema() string {
columns = append(columns, c.SQLiteSchema())
}
if len(s.PrimaryKey) != 0 {
primaryKeys := make([]string, len(s.PrimaryKey))

for i, key := range s.PrimaryKey {
primaryKeys[i] = fmt.Sprintf("%s COLLATE zetasqlite_collate", key)
}

columns = append(
columns,
fmt.Sprintf("PRIMARY KEY (%s)", strings.Join(s.PrimaryKey, ",")),
fmt.Sprintf("PRIMARY KEY (%s)", strings.Join(primaryKeys, ",")),
)
}
var clustering string
if len(s.PrimaryKey) > 0 {
clustering = "WITHOUT ROWID"
} else {
clustering = ""
}
var stmt string
switch s.CreateMode {
case ast.CreateDefaultMode:
Expand All @@ -153,7 +165,7 @@ func (s *TableSpec) SQLiteSchema() string {
case ast.CreateIfNotExistsMode:
stmt = "CREATE TABLE IF NOT EXISTS"
}
return fmt.Sprintf("%s `%s` (%s)", stmt, s.TableName(), strings.Join(columns, ","))
return fmt.Sprintf("%s `%s` (%s) %s", stmt, s.TableName(), strings.Join(columns, ","), clustering)
}

func viewSQLiteSchema(s *TableSpec) string {
Expand Down

0 comments on commit 457aa4c

Please sign in to comment.