Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use WITHOUT ROWID table clustering for primary keys #44

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

ohaibbq
Copy link

@ohaibbq ohaibbq commented Apr 10, 2024

This allows SQLite to do efficient row lookups when used in conjunction with #43
https://www.sqlite.org/withoutrowid.html

Copy link

@ageiduschek ageiduschek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Title of this PR maybe should be Use WITHOUT ROWID table clustering for tables with primary keys, no?

@ohaibbq ohaibbq changed the title Use WITHOUT ROWID table clustering for tables Use WITHOUT ROWID table clustering for primary keys Apr 11, 2024
@ohaibbq
Copy link
Author

ohaibbq commented Apr 11, 2024

Yes!

@ohaibbq ohaibbq closed this Apr 11, 2024
@ohaibbq ohaibbq reopened this Apr 11, 2024
@ohaibbq ohaibbq merged commit 457aa4c into candidate/rb20240201 Apr 11, 2024
13 checks passed
ohaibbq added a commit that referenced this pull request Jun 29, 2024
* Use `WITHOUT ROWID` table clustering for tables

* lint
@ohaibbq ohaibbq deleted the dan/candidate-primary-keys branch July 8, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants