[Date] Implement %y year without century parser / formatter; handle incomplete digits
#8
Conversation
ohaibbq
requested review from
a team,
ageiduschek,
colincadams,
elchao96,
glorialiu,
ethan-oro and
recidinick
| } | ||
|
|
||
| func yearWithoutCenturyFormatter(t *time.Time) ([]rune, error) { | ||
| year := t.Format("2006") |
There was a problem hiding this comment.
@ageiduschek Golang uses a hardcoded datetime for its parse / format string rather than %X etc
https://go.dev/src/time/format.go
// Here is a summary of the components of a layout string. Each element shows by
// example the formatting of an element of the reference time. Only these values
// are recognized. Text in the layout string that is not recognized as part of
// the reference time is echoed verbatim during Format and expected to appear
// verbatim in the input to Parse.
//
// Year: "2006" "06"
// Month: "Jan" "January" "01" "1"
// Day of the week: "Mon" "Monday"
// Day of the month: "2" "_2" "02"
// Day of the year: "__2" "002"
// Hour: "15" "3" "03" (PM or AM)
// Minute: "4" "04"
// Second: "5" "05"
// AM/PM mark: "PM"
RFC3339 = "2006-01-02T15:04:05Z07:00"
internal/function_time_parser.go
Outdated
| @@ -518,6 +518,40 @@ func centuryFormatter(t *time.Time) ([]rune, error) { | |||
| return []rune(fmt.Sprint(t.Year())[:2]), nil | |||
| } | |||
|
|
|||
| func yearWithoutCenturyParser(text []rune, t *time.Time) (int, error) { | |||
| const yearLen = 2 | |||
| if len(text) > yearLen { | |||
There was a problem hiding this comment.
This clause is incorrect for the case of 01-MM-DD. I will need to update this.
A related issue is Recidiviz/recidiviz-data#20756
BigQuery generally allows non-zero leading dates, but the emulator does not.
There was a problem hiding this comment.
This has been updated to fix goccy#137
ohaibbq
changed the title
%y year without century parser / formatter%y year without century parser / formatter; handle incomplete digits
| const monthLen = 2 | ||
| if len(text) < monthLen { | ||
| return 0, fmt.Errorf("unexpected month number") | ||
| func parseDigitRespectingOptionalPlaces(text []rune, minNumber int64, maxNumber int64) (int, int64, error) { |
There was a problem hiding this comment.
I'd love a closer look at this function. All test cases seem to show it working well, but I'm not sure how understandable it is! @ageiduschek @colincadams
There was a problem hiding this comment.
Oh whoops approved before I saw this comment. I think it could be useful to add a docstring at the beginning of the function to explain what an "optional place" is and give a few examples.
Closes Recidiviz/recidiviz-data#20755
From the docs,
%yis as follows:The note about
%Cin the documentation refers to how to interpret the results of%yrather than saying that it is an alias of the element