-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Page drawer implementation enhancement #1279
Comments
@mattnolting I agree that the layout is quite strange now. However, we now face the "problem" that we need to support old applications in chrome 2 which require a slightly different layout. For example, we have two We first have to wait for all apps to be migrated to the chrome 2 build. And I don't think that will happen before the summit. But I will add it to the list of post-summit cleanup. |
@Hyperkid123 Awesome, thanks! |
@mattnolting we can finally deal with these DOM issues. The DOM structure should be fine not. But we have more than one drawer ATM. One is for quickstart and one for help topics. I am trying to communicate and find a solution with the PF quickstart devs. |
Current structure is:
This causes a height issue as
.pf-c-drawer
defines that, and it's missing.Is should be:
Making this change should eliminate the need for https://github.com/RedHatInsights/insights-chrome/blob/master/src/sass/chrome.scss#L91, which causes issues in various apps..
The text was updated successfully, but these errors were encountered: