Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHCLOUD-32399 update link #2829

Merged
merged 3 commits into from
May 6, 2024
Merged

Conversation

aferd
Copy link
Contributor

@aferd aferd commented May 2, 2024

Jira - https://issues.redhat.com/browse/RHCLOUD-32399
Update link so that on hover affect is only on the link text and not the bundle subtext.

@aferd aferd requested a review from a team May 2, 2024 17:55
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.54%. Comparing base (3194dee) to head (e32d4e0).

❗ Current head e32d4e0 differs from pull request most recent head 27c96c9. Consider uploading reports for the commit 27c96c9 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2829   +/-   ##
=======================================
  Coverage   63.54%   63.54%           
=======================================
  Files         199      199           
  Lines        4301     4301           
  Branches      777      777           
=======================================
  Hits         2733     2733           
  Misses       1559     1559           
  Partials        9        9           

Copy link
Contributor

@Hyperkid123 Hyperkid123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have some invalid DOM nesting. Can you remove the double a tag as well? And have just one.

image

@Hyperkid123 Hyperkid123 merged commit abcd25e into RedHatInsights:master May 6, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants