Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace sentry var to check for app names #2837

Merged
merged 1 commit into from
May 16, 2024

Conversation

adonispuente
Copy link
Contributor

Just for proof of concept, I want sentry to check for advisor in the url. Currently only insights apps are using sentry regardless so no need to check if its insights or any other group like ansible.

Source maps are currently up for Advisor. With this change I can further investigate mapping against source maps with a wrapper and 'consumed' app.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.62%. Comparing base (47a44de) to head (c76c4f5).

❗ Current head c76c4f5 differs from pull request most recent head 499d521. Consider uploading reports for the commit 499d521 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2837   +/-   ##
=======================================
  Coverage   63.62%   63.62%           
=======================================
  Files         201      201           
  Lines        4316     4316           
  Branches      778      778           
=======================================
  Hits         2746     2746           
  Misses       1561     1561           
  Partials        9        9           
Files Coverage Δ
src/utils/sentry.ts 16.21% <100.00%> (ø)

@Hyperkid123 Hyperkid123 merged commit 9c3ec4d into RedHatInsights:master May 16, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants