Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments for env prefix constants + minor refactoring #139

Merged
merged 2 commits into from
Jul 27, 2020

Conversation

tisnik
Copy link
Collaborator

@tisnik tisnik commented Jul 27, 2020

Description

Comments for env prefix constants + minor refactoring

Type of change

  • Refactor (refactoring code, removing useless files)

Testing steps

N/A

@codecov-commenter
Copy link

Codecov Report

Merging #139 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #139      +/-   ##
==========================================
- Coverage   49.58%   49.52%   -0.06%     
==========================================
  Files          11       11              
  Lines         954      953       -1     
==========================================
- Hits          473      472       -1     
  Misses        422      422              
  Partials       59       59              
Impacted Files Coverage Δ
conf/configuration.go 70.37% <ø> (-0.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 414f485...f005092. Read the comment docs.

@tisnik tisnik merged commit ba2cd86 into RedHatInsights:master Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants