Use specific type for exit code #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tisnik
requested review from
Bee-lee,
bond95,
joselsegura,
natiiix,
quarckster and
Serhii1011010
as code owners
| // ExitCode represents numeric value returned to parent process when the | ||
| // current process finishes | ||
| type ExitCode int | ||
|
|
||
| const ( | ||
| // ExitStatusOK means that the service have finished with success | ||
| ExitStatusOK = iota |
There was a problem hiding this comment.
I think we could use ExitCode as a type here
Serhii1011010
approved these changes
Jul 27, 2020
Codecov Report
@@ Coverage Diff @@
## master #141 +/- ##
=======================================
Coverage 49.58% 49.58%
=======================================
Files 11 11
Lines 954 954
=======================================
Hits 473 473
Misses 422 422
Partials 59 59
Continue to review full report at Codecov.
|
joselsegura
approved these changes
Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use specific type for exit code
Type of change
Testing steps
N/A