Don't install utils if already installed #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tisnik
requested review from
Bee-lee,
bond95,
joselsegura,
natiiix,
quarckster and
Serhii1011010
as code owners
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
==========================================
+ Coverage 30.46% 33.49% +3.03%
==========================================
Files 10 10
Lines 627 627
==========================================
+ Hits 191 210 +19
+ Misses 411 393 -18
+ Partials 25 24 -1
Continue to review full report at Codecov.
|
Bee-lee
approved these changes
Jun 24, 2020
This was referenced Jun 24, 2020
| @@ -26,7 +26,11 @@ if [[ $* == *verbose* ]]; then | |||
| VERBOSE=true | |||
| fi | |||
|
|
|||
| GO111MODULE=off go get -u github.com/droptheplot/abcgo | |||
| if ! [ -x "$(command -v abcgo)" ] | |||
There was a problem hiding this comment.
Then -u option doesn't make sense here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Don't install utils if already installed
(the same change that was incorporated into aggregator)
Fixes #50 #51 #52 #53 #54 #55 #56
Type of change
Testing steps
Can be checked by running all updated scripts - it is much much faster now.