Fix URL constructor when called with base argument #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redfire75369
requested changes
Nov 2, 2023
| let base = base.as_ref().and_then(|base| Url::parse(base).ok()); | ||
| options.base_url(base.as_ref()); | ||
| let url = options.parse(&input).map_err(|error| Error::new(&error.to_string(), None))?; | ||
| let base = base.as_ref().and_then(|base| url::Url::parse(base).ok()); |
There was a problem hiding this comment.
You can directly use Url::parse here, without fully qualifying the path.
| options.base_url(base.as_ref()); | ||
| let url = options.parse(&input).map_err(|error| Error::new(&error.to_string(), None))?; | ||
| let base = base.as_ref().and_then(|base| url::Url::parse(base).ok()); | ||
| let url = url::Url::options() |
There was a problem hiding this comment.
Same as above, but with Url::options.
|
Thanks for the fix, I'll make a PR upstream to address this problem. Edit: servo/rust-url#876 |
|
Fixed in 38c4177 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes constructing a URL with a base. Since
Url::optionsis meant to be used with fluent syntax, callingoptions.base_urlwithout storing the result has no effect.Confusingly,
ParseOptionsimplementsCopy, which prevented this error from being caught by the compiler.