Skip to content

Conversation

@meiravgri
Copy link
Collaborator

Initially intented to backport #819 to 0.6, but here there's no need to ditniguish between capcity to metadata capacity in this branch

So just some benchmarks asserts fixed

@codecov
Copy link

codecov bot commented Nov 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.31%. Comparing base (9b8211f) to head (1452ae1).
⚠️ Report is 1 commits behind head on 0.6.

Additional details and impacted files
@@            Coverage Diff             @@
##              0.6     #826      +/-   ##
==========================================
+ Coverage   95.08%   95.31%   +0.22%     
==========================================
  Files          60       60              
  Lines        3460     3371      -89     
==========================================
- Hits         3290     3213      -77     
+ Misses        170      158      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@meiravgri meiravgri requested a review from GuyAv46 November 4, 2025 12:12
@meiravgri meiravgri enabled auto-merge November 4, 2025 12:14
Comment on lines +204 to +205
size_t curr_cap = index->indexCapacity();
assert(curr_cap == index_cap);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Call from the assert, so when we build without asserts it will be optimized away (and also to be aligned with other asserts here)

Suggested change
size_t curr_cap = index->indexCapacity();
assert(curr_cap == index_cap);
assert(index->indexCapacity() == index_cap);

@meiravgri meiravgri added this pull request to the merge queue Nov 4, 2025
Merged via the queue into 0.6 with commit 32abd2a Nov 4, 2025
22 checks passed
@meiravgri meiravgri deleted the backport-819-to-0.6 branch November 4, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants