-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC-440 K8s guides for 'Developer Guides' #1173
Conversation
aliases: | ||
--- | ||
|
||
Configuring a replica of database can be accomplished by creating an item in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use the active voice: https://developers.google.com/style/voice
Co-authored-by: Kyle Banker <banker@users.noreply.github.com>
Co-authored-by: Kyle Banker <banker@users.noreply.github.com>
Co-authored-by: Kyle Banker <banker@users.noreply.github.com>
Co-authored-by: Kyle Banker <banker@users.noreply.github.com>
Co-authored-by: Kyle Banker <banker@users.noreply.github.com>
Co-authored-by: Kyle Banker <banker@users.noreply.github.com>
Co-authored-by: Kyle Banker <banker@users.noreply.github.com>
Co-authored-by: Amiram Mizne <amiramm@users.noreply.github.com>
At this, we can test our “dev” customization by running the folliwing: | ||
|
||
``` | ||
kubectl kustomize dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This confused me, since you earlier say to run it using kubectl apply -k
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kubectl apply -k
applys the configuration to the cluster and kubectl kustomize dev
just runs the kustomize process locally and shows you the output.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed that sentence now.
@amiramm or @alexmilowski: Can you take one last look at my changes here? If you agree, I'll merge. |
I've reviewed the changes. They all look good. I fixed one typo/clarification in the first use of the kustomize command as per the comment above. This is ready to be merged if you agree with that change. |
Merged from #1008 for style review