Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-440 K8s guides for 'Developer Guides' #1173

Merged
merged 14 commits into from
Jan 12, 2021

Conversation

bmansheim
Copy link
Contributor

@bmansheim bmansheim commented Jan 6, 2021

Merged from #1008 for style review

content/platforms/kubernetes/tasks/ldap-on-k8s.md Outdated Show resolved Hide resolved
content/platforms/kubernetes/tasks/ldap-on-k8s.md Outdated Show resolved Hide resolved
content/platforms/kubernetes/tasks/ldap-on-k8s.md Outdated Show resolved Hide resolved
content/platforms/kubernetes/tasks/ldap-on-k8s.md Outdated Show resolved Hide resolved
content/platforms/kubernetes/tasks/ldap-on-k8s.md Outdated Show resolved Hide resolved
content/platforms/kubernetes/tasks/replica-of-k8s.md Outdated Show resolved Hide resolved
aliases:
---

Configuring a replica of database can be accomplished by creating an item in
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the active voice: https://developers.google.com/style/voice

content/platforms/kubernetes/tasks/using-kustomnize.md Outdated Show resolved Hide resolved
alexmilowski and others added 5 commits January 8, 2021 10:57
Co-authored-by: Kyle Banker <banker@users.noreply.github.com>
Co-authored-by: Kyle Banker <banker@users.noreply.github.com>
Co-authored-by: Kyle Banker <banker@users.noreply.github.com>
Co-authored-by: Kyle Banker <banker@users.noreply.github.com>
Co-authored-by: Kyle Banker <banker@users.noreply.github.com>
@amiramm amiramm self-requested a review January 8, 2021 20:36
amiramm and others added 2 commits January 8, 2021 12:44
Co-authored-by: Kyle Banker <banker@users.noreply.github.com>
Co-authored-by: Kyle Banker <banker@users.noreply.github.com>
banker and others added 2 commits January 11, 2021 17:36
Co-authored-by: Amiram Mizne <amiramm@users.noreply.github.com>
At this, we can test our “dev” customization by running the folliwing:

```
kubectl kustomize dev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This confused me, since you earlier say to run it using kubectl apply -k

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kubectl apply -k applys the configuration to the cluster and kubectl kustomize dev just runs the kustomize process locally and shows you the output.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed that sentence now.

@banker
Copy link
Contributor

banker commented Jan 12, 2021

@amiramm or @alexmilowski: Can you take one last look at my changes here? If you agree, I'll merge.

@alexmilowski
Copy link
Contributor

I've reviewed the changes. They all look good. I fixed one typo/clarification in the first use of the kustomize command as per the comment above. This is ready to be merged if you agree with that change.

@banker banker merged commit 23c726f into master Jan 12, 2021
@banker banker deleted the DOC-440-k8s-guides-for-developers branch January 12, 2021 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Additional information or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants