Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update password-rotation.md #1355

Merged
merged 3 commits into from
May 10, 2021
Merged

Update password-rotation.md #1355

merged 3 commits into from
May 10, 2021

Conversation

yanivhershkovich
Copy link
Contributor

Few issues on this page:

  1. It doesn't seem like it will work on the database default access so there's a pre-requisite of adding custom users through ACLs to the database before you can add/rotate passwords. We should either mention that condition as a note/comment or include steps to a user/redirect to the ACLs page.
  2. The API commands are broken to new lines and if a customer copies them as is, they won't work. It has to be a single line (I did the modification).
  3. Fixed a minor typo ('an user' to 'a user' in two places).
  4. Document title is 'Database Password Rotation' but it actually applies to all users, UI and Database and not only Database. We should consider renaming it but this is minor.

Few issues on this page:
1. It doesn't seem like it will work on the database default access so there's a pre-requisite of adding custom users through ACLs to the database before you can add/rotate passwords. We should either mention that condition as a note/comment or include steps to a user/redirect to the ACLs page.
2. The API commands are broken to new lines and if a customer copies them as is, they won't work. It has to be a single line (I did the modification).
3. Fixed a minor typo ('an user' to 'a user' in two places).
4. Document title is 'Database Password Rotation' but it actually applies to all users, UI and Database and not only Database.
@kaitlynmichael
Copy link
Contributor

@yanivhershkovich this section is currently under "Administration" but I think it would be better under the "Security" section. Do you agree?

@yanivhershkovich
Copy link
Contributor Author

@kaitlynmichael I don't think so since this is about DB administration (i.e. password rotation) but if the PMs think it should move to security, I have no objection as long as we fix the issues in the page.

@kaitlynmichael
Copy link
Contributor

@yanivhershkovich do you think "User password rotation" would be a better title?

@yanivhershkovich
Copy link
Contributor Author

Yes, it might be better since it applies to both UI and DB users but I'll let the PMs decide :)

@AlonMagrafta
Copy link
Contributor

@yanivhershkovich Thanks!

@kaitlynmichael kaitlynmichael merged commit 3cfddd2 into master May 10, 2021
@kaitlynmichael kaitlynmichael deleted the yanivhershkovich-patch-2 branch May 10, 2021 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants