Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jira DOC-716: Fix broken links in in-page table of contents #1376

Merged
merged 5 commits into from
May 27, 2021

Conversation

lanceleonard
Copy link
Contributor

No description provided.

@lanceleonard lanceleonard self-assigned this May 19, 2021
Copy link
Contributor

@banker banker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments.

content/embeds/hardware-requirements-embed.md Outdated Show resolved Hide resolved
content/embeds/hardware-requirements-embed.md Outdated Show resolved Hide resolved
content/embeds/hardware-requirements-embed.md Outdated Show resolved Hide resolved
content/rs/installing-upgrading/_index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@AlonMagrafta AlonMagrafta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left few comments.
In general worth discussing on our next meeting.
It's a great page, my only concern is that it is a bit long and has some steps that are optional, maybe there is a visual way we can collapse them to make a lighter page vibe.
My suspects are:

  • Custom installation directories
  • Customize system user and group
  • Installation questions
  • Silent install

Copy link
Contributor

@kaitlynmichael kaitlynmichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion, otherwise LGTM

@lanceleonard lanceleonard merged commit 4878c47 into master May 27, 2021
@lanceleonard lanceleonard deleted the jira-doc-716 branch May 27, 2021 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants