Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V3] Animelist #115

Open
1 of 3 tasks
Stonedestroyer opened this issue May 23, 2018 · 5 comments
Open
1 of 3 tasks

[V3] Animelist #115

Stonedestroyer opened this issue May 23, 2018 · 5 comments

Comments

@Stonedestroyer
Copy link

Note: for support questions, please use the Cog Support Server. This repository's issues are reserved for feature requests and bug reports.

I'm submitting a ...

  • bug report
  • feature request
  • support request => Please do not submit support request here, see note at the top of this template.

Cog Information

Name: AnimeList
Version: V3

Feature Description

Please include the motivation / use case for this feature.
It would make it look nicer. I tried doing this with replace but it seems regex would be better suited as these values are the same score is always 0.00 if unspecified which can be changed to N/A as per site to adhere to site look.

Start_date = Start Date
End_date  = End Date
0000-00-00 = ?
0.00 = N/A
0 = Unknown

ypou8hm

@skeith
Copy link
Collaborator

skeith commented May 23, 2018

I think 0000-00-00 = Unknown is better

@Stonedestroyer
Copy link
Author

Probably is, I was just following the example on here https://myanimelist.net/manga/110615/Arifureta_Shokugyou_de_Sekai_Saikyou_Zero where it says ? but for a format to show in Discord I guess it could also be unknown.

@Redjumpman
Copy link
Owner

I'm assuming that it says 0000-00-00 to be used as a placeholder date, but it means that the anime is hasn't finished. This is a pretty easy change, so I'll look to adding it. I'll mostly likely change that to "Currently Airing". There are some other anime that have a definitive year that is planned to end. Possibly due to not having a set renewal yet. For example, black clover says that it is 2018-00-00. Even if you count the weeks for the remaining episodes, sometimes Japan has events or a special air time that interferes with the release schedule.

@skeith
Copy link
Collaborator

skeith commented May 23, 2018

How about this, have End date check for its Status. If Status not Finished, use Status as End Date

@Redjumpman
Copy link
Owner

That would work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants