-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add assistant to edit hazard analysis user defined functions #1011
Conversation
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 0.11%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Codecov Report
@@ Coverage Diff @@
## master #1011 +/- ##
=======================================
Coverage 94.94% 94.94%
=======================================
Files 185 185
Lines 5339 5339
Branches 509 509
=======================================
Hits 5069 5069
Misses 235 235
Partials 35 35
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Does this PR introduce a breaking change?
Describe the purpose of this pull request.
To add an assistant for entering user defined hazard analysis functions.
Describe how this was implemented.
Converted Similar Item user defined function editing assistant to a generic function edit assistant. Updated Similar Item work view to use the generic assistant. Added a button to the Hazard Analysis to call this generic assistant to edit user defined hazard analysis functions.
Describe any particular area(s) reviewers should focus on.
None
Provide any other pertinent information.
Closes #955
Pull Request Checklist
Code Style
Static Checks
this PR.
Tests
Chores
this PR. These problem areas have been decorated with an ISSUE: # comment.