refactor: remove if-else control block in do_select_all() method #1019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: refactor
github-actions
bot
added
the
status: inprogress
|
SonarCloud Quality Gate failed.
|
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 0.03%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Codecov Report
@@ Coverage Diff @@
## master #1019 +/- ##
==========================================
- Coverage 94.81% 94.80% -0.02%
==========================================
Files 144 144
Lines 5249 5194 -55
Branches 509 508 -1
==========================================
- Hits 4977 4924 -53
+ Misses 235 233 -2
Partials 37 37
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
trafico-bot
bot
added
the
endgame: merged
weibullguy
added
status: closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR introduce a breaking change?
Describe the purpose of this pull request.
To remove the deprecated approach in the do_select_all() method and to update pubsub messages and subscribers to use singular version of the _tag attribute.
Describe how this was implemented.
Removed if-else control block; only kept the else portion. Removed the _deprecated class attribute from all table models. Updated test suite.
Describe any particular area(s) reviewers should focus on.
None
Provide any other pertinent information.
Closes #1000
Pull Request Checklist
Code Style
Static Checks
this PR.
Tests
Chores
this PR. These problem areas have been decorated with an ISSUE: # comment.