Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add derating criteria for fuse, relay, resistor, and switch #1051

Merged
merged 22 commits into from
Apr 14, 2022

Conversation

weibullguy
Copy link
Collaborator

@weibullguy weibullguy commented Apr 14, 2022

Does this PR introduce a breaking change?

  • Yes
  • No

Describe the purpose of this pull request.

To add derating criteria for various components.

Describe how this was implemented.

Re-wrote derating criteria code to use SD-18 derating criteria.

Describe any particular area(s) reviewers should focus on.

None

Provide any other pertinent information.

Closes #26
Closes #27
Closes #28
Closes #38

Pull Request Checklist

  • Code Style

    • Code is following code style guidelines.
  • Static Checks

    • Failing static checks are only applicable to code outside the scope of
      this PR.
  • Tests

    • At least one test for all newly created functions/methods?
  • Chores

    • Issue(s) have been raised for problem areas outside the scope of
      this PR. These problem areas have been decorated with an ISSUE: # comment.

@github-actions github-actions bot added bump: minor Issue or PR documents a new feature requiring a minor version bump. type: feature Issue or PR adds or requests new functionality. labels Apr 14, 2022
@weibullguy weibullguy self-assigned this Apr 14, 2022
@github-actions github-actions bot added the status: inprogress Issue or PR is open, milestoned, and assigned. label Apr 14, 2022
@sonarcloud
Copy link

sonarcloud bot commented Apr 14, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
22.8% 22.8% Duplication

@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #1051 (5f50409) into master (109a0af) will increase coverage by 0.32%.
The diff coverage is 94.75%.

@@            Coverage Diff             @@
##           master    #1051      +/-   ##
==========================================
+ Coverage   95.20%   95.52%   +0.32%     
==========================================
  Files         144      155      +11     
  Lines        5400     5588     +188     
  Branches      581      612      +31     
==========================================
+ Hits         5141     5338     +197     
+ Misses        230      224       -6     
+ Partials       29       26       -3     
Flag Coverage Δ
3.10 95.52% <94.73%> (+0.32%) ⬆️
3.7 95.52% <94.75%> (+0.32%) ⬆️
3.8 95.52% <94.75%> (+0.32%) ⬆️
3.9 95.52% <94.75%> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/ramstk/analyses/__init__.py 100.00% <ø> (ø)
src/ramstk/configuration.py 89.75% <64.28%> (+3.63%) ⬆️
src/ramstk/analyses/derating/__init__.py 100.00% <100.00%> (ø)
src/ramstk/analyses/derating/derating.py 100.00% <100.00%> (ø)
src/ramstk/analyses/derating/models/__init__.py 100.00% <100.00%> (ø)
src/ramstk/analyses/derating/models/capacitor.py 100.00% <100.00%> (ø)
src/ramstk/analyses/derating/models/connection.py 100.00% <100.00%> (ø)
src/ramstk/analyses/derating/models/inductor.py 100.00% <100.00%> (ø)
...mstk/analyses/derating/models/integratedcircuit.py 100.00% <100.00%> (ø)
src/ramstk/analyses/derating/models/lamp.py 100.00% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 109a0af...5f50409. Read the comment docs.

@weibullguy weibullguy merged commit 56ba6ab into master Apr 14, 2022
@trafico-bot trafico-bot bot added the endgame: merged Pull Request has been merged successfully label Apr 14, 2022
@github-actions github-actions bot added status: closed Pull Request is complete and integrated or closed for anther reason. and removed status: inprogress Issue or PR is open, milestoned, and assigned. labels Apr 14, 2022
@weibullguy weibullguy deleted the feat/issue-38 branch April 14, 2022 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump: minor Issue or PR documents a new feature requiring a minor version bump. endgame: merged Pull Request has been merged successfully status: closed Pull Request is complete and integrated or closed for anther reason. type: feature Issue or PR adds or requests new functionality.
Projects
None yet
1 participant