Close debug panel tabs when client stopped #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of unwrapping send client stopped event to close all the panes that belong to that client
RemcoSmitsDev
changed the title
RemcoSmitsDev
force-pushed
the
close-debug-panel-when-client-stopped
branch
from
854e505
to
e95f9b6
Compare
RemcoSmitsDev
changed the title
Anthony-Eid
approved these changes
Aug 21, 2024
| @@ -94,6 +94,9 @@ impl DebugPanelItem { | |||
| DebugPanelEvent::Output((client_id, event)) => { | |||
| Self::handle_output_event(this, client_id, event, cx) | |||
| } | |||
| DebugPanelEvent::ClientStopped(client_id) => { | |||
| Self::handle_client_stopped_event(this, client_id, cx) | |||
There was a problem hiding this comment.
I think it would be more readable to call the function using this e.g this.handle_client_stopped_event(client_id, cx)
Not a blocking issue for a PR though
There was a problem hiding this comment.
We can change them, will do in another pr
| client_id: &DebugAdapterClientId, | ||
| cx: &mut ViewContext<Self>, | ||
| ) { | ||
| if Self::should_skip_event(this, client_id, this.thread_id) { |
There was a problem hiding this comment.
Same comment as earlier this.should_skip_event(client_id, this.thread_id) is more readable. Also, I'm not sure it's necessary to pass thread_id to a struct's method when the struct is already aware of that value.
There was a problem hiding this comment.
The method requires it, but i could just check only client is myself. But i think this is more self explaining and its inline with the other event handles. So its more consistent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.